Remove externalComplex test completely. #9257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out test as it has caused CI issues for weeks now. swiftlang#9249
kcieplak
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
bkhouri
requested changes
Oct 17, 2025
| // https://github.com/swiftlang/swift-package-manager/issues/9249 | ||
|
|
||
| // @Test( | ||
| // .IssueWindowsLongPath, |
There was a problem hiding this comment.
Issue ( blocking): instead of commenting out this test, add a .disabled() and .issue() traits to ensure, that at a minimum, the the test still compiles.
|
Is there a GitHub issue tracking re-enablement of this test? |
|
Is this change needed after #9256? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment out test as it has caused CI issues for weeks now.
#9249