Add per-table cache for cl column #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somtochiama
changed the title
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
reviewed
Nov 9, 2025
gorbak25
approved these changes
Nov 9, 2025
gorbak25
left a comment
gorbak25
left a comment
There was a problem hiding this comment.
lgtm. Mostly nits. Looking forward to see a cache for get_or_create_key in the future.
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
somtochiama
force-pushed
the
add-ordinal-map
branch
from
a5cffe1 to
7159d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a per-table map that caches the cl for each pk within the same transaction to reduce repetitive lookup when merging changes.