fix nits

Signed-off-by: Somtochi Onyekwere <[email protected]>

Author: somtochiama

core/rs/core/src/local_writes/after_insert.rs

@@ -101,22 +101,15 @@ fn update_create_record(
         .map_err(|_e| "failed binding to update_create_record_stmt")?;
 
     let res = update_create_record_stmt.step();
-    match res {
+    let result = match res {
         Ok(ResultCode::ROW) => {
             let col_version = update_create_record_stmt.column_int64(0);
-            super::reset_cached_stmt(update_create_record_stmt.stmt)
-                .map_err(|_e| "failed to reset cached stmt")?;
             Ok(Some(col_version))
         }
-        Ok(ResultCode::DONE) => {
-            super::reset_cached_stmt(update_create_record_stmt.stmt)
-                .map_err(|_e| "failed to reset cached stmt")?;
-            Ok(None)
-        }
-        _ => {
-            super::reset_cached_stmt(update_create_record_stmt.stmt)
-                .map_err(|_e| "failed to reset cached stmt")?;
-            Err("failed to step update_create_record_stmt".to_string())
-        }
-    }
+        Ok(ResultCode::DONE) => Ok(None),
+        _ => Err("failed to step update_create_record_stmt".to_string()),
+    };
+    super::reset_cached_stmt(update_create_record_stmt.stmt)
+        .map_err(|_e| "failed to reset cached stmt")?;
+    result
 }

core/rs/core/src/local_writes/after_update.rs

@@ -85,7 +85,7 @@ fn after_update(
         if crate::compare_values::any_value_changed(pks_new, pks_old)? {
             let old_key = tbl_info
                 .get_or_create_key_via_raw_values(db, pks_old)
-                .map_err(|_| "failed geteting or creating lookaside key")?;
+                .map_err(|_| "failed getting or creating lookaside key")?;
             let next_seq = super::bump_seq(ext_data);
             changed = true;
             // Record the delete of the row identified by the old primary keys

core/rs/core/src/local_writes/mod.rs

@@ -98,20 +98,17 @@ fn mark_new_pk_row_created(
         .and_then(|_| mark_locally_created_stmt.bind_int(3, seq))
         .and_then(|_| mark_locally_created_stmt.bind_text(4, ts, sqlite::Destructor::STATIC))
         .map_err(|_| "failed binding to mark_locally_created_stmt")?;
-    let res = mark_locally_created_stmt.step();
-    match res {
+    let stmt_res = mark_locally_created_stmt.step();
+    let result = match stmt_res {
         Ok(ResultCode::ROW) => {
             let cl = mark_locally_created_stmt.column_int64(0);
-            reset_cached_stmt(mark_locally_created_stmt.stmt)
-                .map_err(|_e| "failed to reset cached stmt")?;
             Ok(cl)
         }
-        _ => {
-            reset_cached_stmt(mark_locally_created_stmt.stmt)
-                .map_err(|_e| "failed to reset cached stmt")?;
-            Err("failed to step mark locally created stmt".to_string())
-        }
-    }
+        _ => Err("failed to step mark locally created stmt".to_string()),
+    };
+    reset_cached_stmt(mark_locally_created_stmt.stmt)
+        .map_err(|_e| "failed to reset cached stmt")?;
+    result
 }
 
 fn bump_seq(ext_data: *mut crsql_ExtData) -> c_int {

core/rs/core/src/tableinfo.rs

@@ -28,6 +28,7 @@ use sqlite_nostd::ResultCode;
 use sqlite_nostd::Stmt;
 use sqlite_nostd::StrRef;
 
+// TODO: make this configurable with a crsql_config_set.
 const MAX_CL_CACHE_SIZE: usize = 1500;
 pub struct TableInfo {
     pub tbl_name: String,