Remove tool type column and rename created at to created in the thv list #2917
Conversation
…list command Signed-off-by: carlos <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 323 323
Lines 31763 31763
=======================================
Hits 17904 17904
Misses 12330 12330
Partials 1529 1529 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| status, | ||
| c.URL, | ||
| c.Port, | ||
| c.ToolType, |
There was a problem hiding this comment.
If we are not displaying the ToolType, I don't think it serves any purpose. Lets delete it from the Workload and all the references.
@dmjb wdyt?
There was a problem hiding this comment.
Agreed, but let's do it in a separate PR, since I want to avoid breaking the API contract (even if the field is not used).
There was a problem hiding this comment.
Can I do it? It will help me learn the project 😁
There was a problem hiding this comment.
I created the issue for this. I am unable to assign it to you, it would be great if you please assign it to yourself.
There was a problem hiding this comment.
If you comment on the issue then we'll be able to assign it to you @carlos-gn. GitHub won't let us assign an issue unless you've interacted with it.
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
@chandru-mck-2002 I know you were already working on this issue as well. Could you review this PR and see if it aligns with your approach?
github-actions
bot
added
size/XS
4 participants
Fix #2876 and #2878