-
Notifications
You must be signed in to change notification settings - Fork 153
Open
Labels
apiItems related to the APIItems related to the APIcliChanges that impact CLI functionalityChanges that impact CLI functionalityenhancementNew feature or requestNew feature or requestgoPull requests that update go codePull requests that update go codegood first issueGood for newcomersGood for newcomers
Description
We will remove the ToolType column in PR, but it is still part of the Workload struct. ToolType always points to either "mcp" (for container workloads) or "remote" (for remote workloads). It was initially created to differentiate between mcp and other tool types, but MCP seems to stand out without any other type. We can safely remove this field and all its references.
Scope of changes:
- Remove
ToolTypefield fromcore.Workloadstruct - Remove
LabelToolTypeandGetToolTypefrom labels package - Simplify
shouldSkipWorkloadlogic in client manager (currently checksToolType != "mcp" && !Remote, can be simplified to just checkRemotefield) - Remove ToolType from list command output
- Remove ToolType from backend metadata (or keep hardcoded "mcp" in VMCP if needed for external systems)
- Update tests and API documentation
Metadata
Metadata
Assignees
Labels
apiItems related to the APIItems related to the APIcliChanges that impact CLI functionalityChanges that impact CLI functionalityenhancementNew feature or requestNew feature or requestgoPull requests that update go codePull requests that update go codegood first issueGood for newcomersGood for newcomers