feat: Remove native-stack v5 from screens repo #3433
Conversation
kmichalikk
added
Area: JS-only
kmichalikk
force-pushed
the
@kmichalikk/remove-native-stack-v5
branch
from
8e653e6 to
1c9f539
Compare
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Guide: this is a feature related change, as it modifies public interface of the library, therefore use feat as the commit type in the PR title.
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Looks nice. I just have few comments.
There was a problem hiding this comment.
Does this test case even work? I think that we never downstreamed this feature to react-navigation. There was a PR from @maciekstosio, but it has not been completed.
Please verify whether we have ticket for downstreaming it (I think I recently saw one on the board, it could have been a draft so it won't be visible in labs issues). If not -> create one.
Now, regarding this test -> if it does not work, it should be "suspended". I'd recommend commenting it out in index file, so that it is not loaded or marking it somehow as "disabled" (can be done in separate, follow up PR).
There was a problem hiding this comment.
This is the PR:
react-navigation/react-navigation#12225
There was a problem hiding this comment.
kmichalikk
changed the title
## Description This PR removes TestScreenAnimationV5. This test is showing a functionality that is not completed on react-navigation side. ## Changes Commented out TestScreenAnimationV5. ## Test code and steps to reproduce Check if TestScreenAnimationV5 is present in the Example list, it should not.
kmichalikk
added
Type: Feature
Description
This PR removes native-stack directory from screens repo. This dir held the code for native-stack v5, which has been moved to react-navigation and is v7, v8 now. The rest of the deprecated imports are removed and the unused code is deleted.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/589
Changes
Removed native-stack/*, fixed imports.
Test code and steps to reproduce
Check if the library still builds successfully.