Skip to content

When assembling the text array for an object, skip Forms that don't contain any text, instead of all Forms. #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rupertj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When assembling the text array for an object, skip Forms that don't contain any text, instead of all Forms. #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/Smalot/PdfParser/PDFObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,16 +788,26 @@ public function getTextArray(?Page $page = null): array
break;
}

// If the PDFObject is an Image or a Form, do nothing as
// neither of these XObject types are text.
if ($xobject instanceof Image || $xobject instanceof Form) {
// If the PDFObject is an Image, do nothing as images
// aren't text.
if ($xobject instanceof Image) {
break;
}

// Check this is not a circular reference.
if (!\in_array($xobject->getUniqueId(), self::$recursionStack, true)) {
$text[] = $xobject->getText($page);
if (\in_array($xobject->getUniqueId(), self::$recursionStack, true)) {
break;
}

$objectText = $xobject->getText($page);

// If the PDFObject is a Form and doesn't have any text,
// skip it.
if (($xobject instanceof Form) && ($objectText === ' ')) {
Copy link
Collaborator

@k00ni k00ni Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (($xobject instanceof Form) && ($objectText === ' ')) {
if ($xobject instanceof Form && $objectText === ' ') {

No parentheses required when using a combination of simple checks.

break;
}

$text[] = $objectText;
break;

// Marked content point with (DP) & without (MP) property list
Expand Down