When assembling the text array for an object, skip Forms that don't contain any text, instead of all Forms.#789
Open
rupertj wants to merge 1 commit intosmalot:masterfrom
Open
When assembling the text array for an object, skip Forms that don't contain any text, instead of all Forms.#789rupertj wants to merge 1 commit intosmalot:masterfrom
rupertj wants to merge 1 commit intosmalot:masterfrom
Conversation
…ontain any text, instead of all Forms.
Collaborator
|
Thank you @rupertj.
|
k00ni
added
missing or incomplete functionality
k00ni
reviewed
Feb 9, 2026
|
|
||
| // If the PDFObject is a Form and doesn't have any text, | ||
| // skip it. | ||
| if (($xobject instanceof Form) && ($objectText === ' ')) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (($xobject instanceof Form) && ($objectText === ' ')) { | |
| if ($xobject instanceof Form && $objectText === ' ') { |
No parentheses required when using a combination of simple checks.
Collaborator
|
@gerardnll + @MrMitch Could you please test if it solves your issues in #788 and give me feedback? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #788.