-
Notifications
You must be signed in to change notification settings - Fork 18
Attempt to fix inbound calls on Windows #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main_video_v3
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| "description": "SignalWire JS SDK", | ||
| "author": "SignalWire Team <[email protected]>", | ||
| "license": "MIT", | ||
| "version": "3.29.1", | ||
| "version": "3.29.1-bkw", | ||
| "main": "dist/index.js", | ||
| "module": "dist/index.esm.js", | ||
| "unpkg": "dist/index.umd.js", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,9 @@ export const callSegmentWorker = function* ( | |
| case 'call.room': | ||
| cfRoomSession.emit(type, payload) | ||
| break | ||
| case 'call.state': | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already being emitted in L#58 fabricWorker.ts |
||
| cfRoomSession.emit(type, payload) | ||
| break | ||
|
|
||
| /** | ||
| * The Core module includes a generic worker, {@link memberPositionWorker}, | ||
|
|
@@ -120,17 +123,23 @@ export const callSegmentWorker = function* ( | |
| } | ||
|
|
||
| const isSegmentEvent = (action: SDKActions) => { | ||
| const { type, payload } = action as FabricAction | ||
| const shouldWatch = | ||
| type.startsWith('call.') || | ||
| type.startsWith('member.') || | ||
| type.startsWith('layout.') | ||
| const { payload } = action as FabricAction | ||
|
|
||
| // Check both direct payload fields and nested params (for call.state events) | ||
| const hasSegmentCallId = | ||
| 'call_id' in payload && segmentCallId === payload.call_id | ||
| ('call_id' in payload && segmentCallId === payload.call_id) || | ||
| ('params' in payload && | ||
| 'call_id' in (payload as any).params && | ||
| (payload as any).params.call_id === segmentCallId) | ||
|
|
||
| const hasSegmentRoomSessionId = | ||
| segmentRooSessionId === payload.room_session_id | ||
| (segmentRooSessionId === payload.room_session_id) || | ||
| ('params' in payload && | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This worker don't receive the raw payload from the WS instead it get a the |
||
| 'room_session_id' in (payload as any).params && | ||
| (payload as any).params.room_session_id === segmentRooSessionId) | ||
|
|
||
| if (shouldWatch && (hasSegmentCallId || hasSegmentRoomSessionId)) { | ||
| // Allow ALL events that belong to this segment (no type filtering) | ||
| if (hasSegmentCallId || hasSegmentRoomSessionId) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| return true | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Changeset to manage
devreleases; no need to add developer tags.