Skip to content

Conversation

briankwest
Copy link

feat: enhance WebRTC connection pooling and fix Windows ICE gathering issues

  • Completely rewrite RTCPeerConnectionManager pool management
  • Add pre-warming of connections with prepared transceivers for faster setup
  • Fix Windows incoming call issues where ICE gathering never completes
  • Improve negotiation state handling to prevent infinite loops
  • Add comprehensive debug logging for connection pool operations
  • Enhance transceiver reuse logic with better error handling
  • Add timeout support for answer-type connections (10s vs 3s)
  • Skip renegotiation for answer-type connections to prevent verto.modify spam
  • Add version identifier for tracking custom builds

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2025

⚠️ No Changeset found

Latest commit: c8d4273

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"author": "SignalWire Team <[email protected]>",
"license": "MIT",
"version": "3.29.1",
"version": "3.29.1-bkw",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "3.29.1-bkw",
"version": "3.29.1",

We use Changeset to manage dev releases; no need to add developer tags.

case 'call.room':
cfRoomSession.emit(type, payload)
break
case 'call.state':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already being emitted in L#58 fabricWorker.ts

const hasSegmentRoomSessionId =
segmentRooSessionId === payload.room_session_id
(segmentRooSessionId === payload.room_session_id) ||
('params' in payload &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worker don't receive the raw payload from the WS instead it get a the params object already


if (shouldWatch && (hasSegmentCallId || hasSegmentRoomSessionId)) {
// Allow ALL events that belong to this segment (no type filtering)
if (hasSegmentCallId || hasSegmentRoomSessionId) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldWatch is required since we have other event workers each specialized in some set of events.

@jpsantosbh
Copy link
Collaborator

#1319 fix inboud calls issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants