-
Notifications
You must be signed in to change notification settings - Fork 18
Attempt to fix inbound calls on Windows #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main_video_v3
Are you sure you want to change the base?
Conversation
|
"author": "SignalWire Team <[email protected]>", | ||
"license": "MIT", | ||
"version": "3.29.1", | ||
"version": "3.29.1-bkw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "3.29.1-bkw", | |
"version": "3.29.1", |
We use Changeset to manage dev
releases; no need to add developer tags.
case 'call.room': | ||
cfRoomSession.emit(type, payload) | ||
break | ||
case 'call.state': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already being emitted in L#58 fabricWorker.ts
const hasSegmentRoomSessionId = | ||
segmentRooSessionId === payload.room_session_id | ||
(segmentRooSessionId === payload.room_session_id) || | ||
('params' in payload && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worker don't receive the raw payload from the WS instead it get a the params
object already
|
||
if (shouldWatch && (hasSegmentCallId || hasSegmentRoomSessionId)) { | ||
// Allow ALL events that belong to this segment (no type filtering) | ||
if (hasSegmentCallId || hasSegmentRoomSessionId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldWatch
is required since we have other event workers each specialized in some set of events.
#1319 fix inboud calls issue |
feat: enhance WebRTC connection pooling and fix Windows ICE gathering issues