[auto-pr] #174: [Coding Guideline]: Defect Guideline for CERT C, INT34-C: Do not shift an expression by a negative number of bits or by greater than or equal to the number of bits that exist in the operand

[scrc-cg-pr-from-issue]

This PR was automatically generated from issue #174.

Authored by: @felix91gr

Closes #174.

[netlify]

❌ Deploy Preview for scrc-coding-guidelines failed.

Name	Link
🔨 Latest commit	50f5101
🔍 Latest deploy log	https://app.netlify.com/projects/scrc-coding-guidelines/deploys/68f7fe4e3607420008a011c4

[PLeVasseur]

@felix91gr -- could you add the new tag you're using in another PR?

Note that this fails for the same reason as over in #180, so if you addressed the tags over there, you're good.

[felix91gr]

There are a few things regarding the formatting that I can't quite figure out.

@PLeVasseur who from the core team knows the most about Sphinx? There are a few oddities in rendering that I've noticed as I've seen the document change with the PRs, of which I can't pinpoint the cause. Stuff like some bulleted lists having a lot of spacing between their bullet and their text, to some text of the document being obscured by the page's background. So I was thinking that perhaps I could ask for help in finding the causes of those.

[felix91gr]

(Also I'm doing the tables by hand, as you suggested :) took me a while to get to it, but I'm on it)

[felix91gr]

Also: I just fixed a typo because CI rejected the PR due to some unrelated document having a typo. Should this be on another PR?

Anywho. I'll be fixing the table on the other open PR, you tell me how we should merge the typo fix and then we can finally merge both guidelines x3

[felix91gr]

Nevermind. I'll just fix that in another PR. Otherwise iterating on this one will be a pain.

[felix91gr]

#206 has the typo fix

[PLeVasseur]

Good to see this working with the manual table.

Content-wise this is good.

There's a couple of formatting snags I pointed out.

[PLeVasseur]

The same indentation difference between the first line and successive lines applies here too.

[PLeVasseur]

The same indentation difference between the first line and successive lines applies here too.

[PLeVasseur]

Well that's new 😅

Pulled from here.

5:15:56 PM: Build command from Netlify app                                
5:15:56 PM: ────────────────────────────────────────────────────────────────
5:15:56 PM: ​
5:15:56 PM: $ curl -LsSf https://astral.sh/uv/install.sh | sh && ./make.py
5:15:56 PM: downloading uv 0.9.4 x86_64-unknown-linux-gnu
5:15:56 PM: no checksums to verify
5:15:56 PM: installing to /opt/buildhome/.local/bin
5:15:56 PM:   uv
5:15:56 PM:   uvx
5:15:56 PM: everything's installed!
Using CPython 3.14.0 interpreter at: /opt/buildhome/.local/share/mise/installs/python/3.14.0/bin/python3
5:15:56 PM: Creating virtual environment at: .venv
5:15:56 PM:    Building builder @ file:///opt/build/repo/builder
5:15:56 PM:    Building m2r==0.3.1
5:15:56 PM: Downloading pygments (1.2MiB)
5:15:56 PM: Downloading sphinx-needs (2.5MiB)
5:15:56 PM: Downloading sphinx (3.4MiB)
5:15:56 PM: Downloading babel (9.7MiB)
5:15:56 PM: Downloading sphinx-rtd-theme (7.3MiB)
5:15:56 PM: Downloading ruff (11.1MiB)
5:15:57 PM:    Building rpds-py==0.23.1
5:15:57 PM:    Building markupsafe==3.0.2
5:15:57 PM:    Building watchfiles==1.0.5
5:15:57 PM:  Downloading pygments
5:15:57 PM:  Downloading ruff
5:15:57 PM:  Downloading sphinx-rtd-theme
5:15:57 PM:  Downloading sphinx-needs
5:15:57 PM:  Downloading sphinx
5:15:57 PM:  Downloading babel
5:15:57 PM:   × Failed to build `watchfiles==1.0.5`
5:15:57 PM:   ├─▶ The build backend returned an error
5:15:57 PM:   ╰─▶ Call to `maturin.build_wheel` failed (exit status: 1)
5:15:57 PM:       [stdout]
5:15:57 PM:       Running `maturin pep517 build-wheel -i
      /opt/buildhome/.cache/uv/builds-v0/.tmpZv6bLS/bin/python --compatibility
      off`
5:15:57 PM:       [stderr]
5:15:57 PM:       error: rustup could not choose a version of cargo to run, because one
5:15:57 PM:       wasn't specified explicitly, and no default is configured.
      help: run 'rustup default stable' to download the latest stable release
5:15:57 PM:       of Rust and set it as your default toolchain.
5:15:57 PM:       💥 maturin failed
5:15:57 PM:         Caused by: Cargo metadata failed. Does your crate compile with `cargo
      build`?
5:15:57 PM:         Caused by: `cargo metadata` exited with an error:
5:15:57 PM:       Error: command ['maturin', 'pep517', 'build-wheel', '-i',
5:15:57 PM:       '/opt/buildhome/.cache/uv/builds-v0/.tmpZv6bLS/bin/python',
5:15:57 PM:       '--compatibility', 'off'] returned non-zero exit status 1
5:15:57 PM:       hint: This usually indicates a problem with the package or the build
5:15:57 PM:       environment.
5:15:57 PM:   help: `watchfiles` (v1.0.5) was included because
5:15:57 PM:         `safety-critical-rust-coding-guidelines` (v0.1.0) depends on
5:15:57 PM:         `sphinx-autobuild` (v2024.10.3) which depends on `watchfiles`
5:15:57 PM: ​
5:15:57 PM: "build.command" failed                                        
5:15:57 PM: ────────────────────────────────────────────────────────────────
5:15:57 PM: ​
5:15:57 PM:   Error message
5:15:57 PM:   Command failed with exit code 1: curl -LsSf https://astral.sh/uv/install.sh | sh && ./make.py (https://ntl.fyi/exit-code-1)
5:15:57 PM: ​
5:15:57 PM:   Error location
5:15:57 PM:   In Build command from Netlify app:
5:15:57 PM:   curl -LsSf https://astral.sh/uv/install.sh | sh && ./make.py
5:15:57 PM: ​
5:15:57 PM:   Resolved config
5:15:57 PM:   build:
5:15:57 PM:     command: curl -LsSf https://astral.sh/uv/install.sh | sh && ./make.py
5:15:57 PM:     commandOrigin: ui
5:15:57 PM:     environment:
5:15:57 PM:       - REVIEW_ID
5:15:57 PM:     publish: /opt/build/repo/build/html
5:15:57 PM:     publishOrigin: ui
5:15:57 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
5:15:58 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
5:15:58 PM: Failing build: Failed to build site
5:15:58 PM: Finished processing build request in 12.349s

[PLeVasseur]

I wonder if there's a good way to re-run this.

I see no way immediately to do so when clicking on the failed Netlify step

[felix91gr]

I added some whitespace to the commit message @PLeVasseur, which re-triggered the Netlify deploy. However, it still errors out. So whatever is broken over there, must still be broken 🤔

[PLeVasseur]

Opened #212 to track to resolution so that we can get this build to pass.