Skip to content

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 10, 2025

r? cuviper

compiler-errors and others added 5 commits October 10, 2025 09:20
Signed-off-by: Jonathan Brouwer <[email protected]>
(cherry picked from commit 4787834)
When building with `rust.rpath = false`, every `rustc` invocation needs
to include the library path as well. I particularly ran into this in
`generate_target_spec_json_schema` when testing 1.91-beta in Fedora,
where we do disable rpath for our system builds. The new helper function
will hopefully encourage the right thing going forward.

(cherry picked from commit 03cdcb5)
(cherry picked from commit 95ddfa1)
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 10, 2025
@cuviper
Copy link
Member Author

cuviper commented Oct 10, 2025

@bors try jobs=x86_64-gnu-distcheck

@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

⚠️ Warning ⚠️

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 10, 2025
[beta] backports

try-job: x86_64-gnu-distcheck
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 10, 2025

💔 Test for ccac98e failed: CI. Failed jobs:

@cuviper
Copy link
Member Author

cuviper commented Oct 11, 2025

@bors try jobs=x86_64-gnu-distcheck

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
[beta] backports

try-job: x86_64-gnu-distcheck
@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

☀️ Try build successful (CI)
Build commit: efe3b2b (efe3b2bef183f45728ec12051538a04550a14cd7, parent: 21cd82aa6363f7ceaebefafc528e62124267461c)

@cuviper
Copy link
Member Author

cuviper commented Oct 11, 2025

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

📌 Commit 5bef436 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2025
@bors
Copy link
Collaborator

bors commented Oct 11, 2025

⌛ Testing commit 5bef436 with merge cbf84ed...

@bors
Copy link
Collaborator

bors commented Oct 12, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing cbf84ed to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 12, 2025
@bors bors merged commit cbf84ed into rust-lang:beta Oct 12, 2025
12 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants