Skip to content

Update LLVM to 21.1.3 #147518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update LLVM to 21.1.3 #147518

wants to merge 3 commits into from
+9 −1

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Oct 9, 2025 •
edited by rustbot
Loading

Fixes #146742.

After #146124, we need more space to run x86_64-gnu-distcheck if building LLVM from source. According to the building log, the space freed by free-disk-space-linux.sh is not entirely available.

You are running out of disk space. 
The runner will stop working when the machine runs out of disk space. 
Free space left: 98 MB

disk usage:
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        72G   43G   29G  60% /
tmpfs           7.9G   84K  7.9G   1% /dev/shm
tmpfs           3.2G  1.2M  3.2G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda16      881M   60M  760M   8% /boot
/dev/sda15      105M  6.2M   99M   6% /boot/efi
/dev/sdb1        74G   28K   70G   1% /mnt
tmpfs           1.6G   12K  1.6G   1% /run/user/1001

@rustbot rustbot added A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 9, 2025
@dianqk
Copy link
Member Author

dianqk commented Oct 9, 2025

@bors try jobs=x86_64-gnu-distcheck

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147518 - dianqk:update-llvm, r=<try>
d6659ce 
Update LLVM to 21.1.3

try-job: x86_64-gnu-distcheck
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

💔 Test for d6659ce failed: CI. Failed jobs:

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 9, 2025
@dianqk
Copy link
Member Author

dianqk commented Oct 9, 2025

@bors try jobs=x86_64-gnu-distcheck

rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147518 - dianqk:update-llvm, r=<try>
bfdd4ca 
Update LLVM to 21.1.3

try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@dianqk dianqk marked this pull request as ready for review October 9, 2025 15:25
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

⚠️ Warning ⚠️

@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: bfdd4ca (bfdd4ca14dcc7a1a42c76b7c45521bde578bc92c, parent: acf243778e6c54cb7d54bee4be88e510e4be123e)

@dianqk
Copy link
Member Author

dianqk commented Oct 9, 2025

r? @cuviper
r? @jieyouxu

@rustbot rustbot assigned cuviper and jieyouxu and unassigned Mark-Simulacrum Oct 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@dianqk
Copy link
Member Author

dianqk commented Oct 9, 2025

@cuviper
69215a1 should fix the backported error.

@jieyouxu
Copy link
Member

cc @marcoieni (largedisk runner)

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 10, 2025
@dianqk
Copy link
Member Author

dianqk commented Oct 10, 2025

@bors try jobs=x86_64-gnu-distcheck

rust-bors bot added a commit that referenced this pull request Oct 10, 2025
@rust-bors
Auto merge of #147518 - dianqk:update-llvm, r=<try>
12cd365 
Update LLVM to 21.1.3

try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
Kobzol
Kobzol reviewed Oct 10, 2025
View reviewed changes
Kobzol
Kobzol reviewed Oct 10, 2025
View reviewed changes
@rust-bors
Copy link

rust-bors bot commented Oct 10, 2025

☀️ Try build successful (CI)
Build commit: 12cd365 (12cd36533383877da0ea223da88ded3b5118259a, parent: 9725c4baacef19345e13f91b27e66e10ef5592ae)

@cuviper
Copy link
Member

cuviper commented Oct 10, 2025

r=me for the LLVM update, but I'd like to make sure the bootstrap / infra folks are ok with those changes too.

On that note, would you be willing to approve that "Remove a temporary directory" commit for beta backport as well? I think I would just grab that on top of the already-approved #146953 (which failed distcheck in backport before), since we don't have enough motivation for backporting the additional LLVM changes here AFAIK.

@Kobzol
Copy link
Member

Kobzol commented Oct 10, 2025

You can also r=me for the bootstrap change (or we can land it in a separate PR if that helps for backporting).

@cuviper cuviper mentioned this pull request Oct 10, 2025
Open
cuviper
cuviper reviewed Oct 10, 2025
View reviewed changes
src/bootstrap/src/core/build_steps/test.rs Outdated
.current_dir(plain_src_dir)
.run(builder);
// Mitigate pressure on small-capacity disks.
fs::remove_dir_all(plain_src_dir).unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be builder.remove_dir(..)?

But anyway, somehow this unwrap failed NotFound when I tried it on beta:
#147571 (comment)

I'm not sure how that can be when it was the current_dir of the commands just before!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found there is a dry run before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was close to the answer with my suggested change, and didn't even realize it! 😅

@cuviper
Copy link
Member

cuviper commented Oct 10, 2025

@bors try jobs=x86_64-gnu-distcheck

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 10, 2025
@rust-bors
Auto merge of #147518 - dianqk:update-llvm, r=<try>
b118d5e 
Update LLVM to 21.1.3

try-job: x86_64-gnu-distcheck
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 10, 2025

💔 Test for b118d5e failed: CI. Failed jobs:

@dianqk
Copy link
Member Author

dianqk commented Oct 10, 2025

@bors try jobs=x86_64-gnu-distcheck

rust-bors bot added a commit that referenced this pull request Oct 10, 2025
@rust-bors
Auto merge of #147518 - dianqk:update-llvm, r=<try>
36c699a 
Update LLVM to 21.1.3

try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

☀️ Try build successful (CI)
Build commit: 36c699a (36c699a1a26b4eb1f67c83ab5ae72b041793ad03, parent: 9725c4baacef19345e13f91b27e66e10ef5592ae)

@dianqk
Copy link
Member Author

dianqk commented Oct 11, 2025

@bors r=cuviper,Kobzol rollup=never

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

📌 Commit a3482d9 has been approved by cuviper,Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2025
@jieyouxu jieyouxu removed their assignment Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper left review comments

@Kobzol Kobzol Kobzol left review comments

Assignees

@cuviper cuviper

@Kobzol Kobzol

Labels

A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Matching on enums with optimizations enabled causes rustc-LLVM errors on the nvptx64-nvidia-cuda target

8 participants

@dianqk @rust-log-analyzer @rustbot @jieyouxu @Kobzol @cuviper @bors @Mark-Simulacrum