Fixing misleading Zenoh usage in try-some-example #5954 #5957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@MrBearing thanks for taking care of this.
i think more straight-forward way to roll this back is that,
in this way, it can be easy to track which commits are reverted in the git history.
MrBearing
force-pushed
the
add_rmw_switching_link
branch
from
f371b7d to
4819526
Compare
fujitatomoya
approved these changes
Oct 21, 2025
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
fujitatomoya
force-pushed
the
add_rmw_switching_link
branch
from
4819526 to
3776959
Compare
fujitatomoya
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) # Conflicts: # source/Installation/RHEL-Install-RPMs.rst # source/Installation/Ubuntu-Install-Debs.rst
fujitatomoya
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) Co-authored-by: Takumi Okamoto <[email protected]>
fujitatomoya
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) Co-authored-by: Takumi Okamoto <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Oct 21, 2025
…) (#5977) * Fixing misleading Zenoh usage in try-some-example #5954 (#5957) * Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) # Conflicts: # source/Installation/RHEL-Install-RPMs.rst # source/Installation/Ubuntu-Install-Debs.rst * resolve conflicts. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Takumi Okamoto <[email protected]> Co-authored-by: Tomoya.Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nal commands
Description
On the following documentation page:
📄 Installation Ubuntu (deb packages)
the “try-some-example” section contains the following instruction:
This step asks users to run rmw_zenohd, but the section neither switches the RMW implementation to Zenoh nor installs ros-jazzy-rmw-zenoh-cpp beforehand.
As a result, the command will likely fail or have no effect — and more importantly, it may mislead newcomers into thinking that running rmw_zenohd is always required for ROS 2, even though the example itself does not use Zenoh.
This issue related this PR
Fixes # (5954)
Did you use Generative AI?
No
Additional Information