Allow Path in substitutions, instead of requiring cast to str #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@InvincibleRMC FYI. Feel free to review too. |
InvincibleRMC
approved these changes
May 4, 2025
Contributor
InvincibleRMC
left a comment
InvincibleRMC
left a comment
There was a problem hiding this comment.
Besides @christophebedard comment lgtm.
emersonknapp
force-pushed
the
allow-pathlib-in-substitution
branch
from
a2e655f to
a2a1044
Compare
Contributor
Author
|
Rebased after #868 and resolved conflicts |
christophebedard
requested changes
May 6, 2025
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
allow-pathlib-in-substitution
branch
from
c32fe49 to
6106d28
Compare
Contributor
Author
|
Pulls: #873
|
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
Contributor
Author
|
Pulls: #873
|
christophebedard
approved these changes
May 15, 2025
Contributor
Author
|
@Mergifyio backport humble jazzy kilted |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d) # Conflicts: # launch/launch/substitutions/python_expression.py # launch_xml/test/launch_xml/test_executable.py
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d) # Conflicts: # launch_xml/test/launch_xml/test_executable.py
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d)
Timple
reviewed
Nov 12, 2025
launch/launch/launch_description_sources/python_launch_file_utilities.py
Show resolved
Hide resolved
emersonknapp
added a commit
that referenced
this pull request
Nov 14, 2025
[kilted] Allow Path in substitutions, instead of requiring cast to str (backport #873)
ahcorde
pushed a commit
that referenced
this pull request
Dec 1, 2025
… (backport #873) (#927) * Allow Path in substitutions, instead of requiring cast to str (#873) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d) Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Emerson Knapp <[email protected]> Co-authored-by: Emerson Knapp <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Dec 1, 2025
…r (backport #873) (#926) * Allow Path in substitutions, instead of requiring cast to str (#873) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d) Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Emerson Knapp <[email protected]> Co-authored-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #805
Closes robograph-project/planning#12
Replaces #790
Related to #868
Allow passing
pathlib.Pathobjects directly into contexts expecting aSubstitution, for more natural modern pythonic usage. For exampleIncludeLaunchDescription(Path(__file__).parent / 'file_in_this_dir_launch.yaml'))As part of this change, stop doing
str(Path)casts everywhere it's done for this reason.