-
Notifications
You must be signed in to change notification settings - Fork 159
[humble] Allow Path in substitutions, instead of requiring cast to str (backport #873) #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 49bcf2d) # Conflicts: # launch/launch/substitutions/python_expression.py # launch_xml/test/launch_xml/test_executable.py
|
Cherry-pick of 49bcf2d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Emerson Knapp <[email protected]>
ec5d515 to
25ed1d7
Compare
|
Pulls: #926 |
|
Pulls: #926 |
Closes #805
Closes robograph-project/planning#12
Replaces #790
Related to #868
Allow passing
pathlib.Pathobjects directly into contexts expecting aSubstitution, for more natural modern pythonic usage. For exampleIncludeLaunchDescription(Path(__file__).parent / 'file_in_this_dir_launch.yaml'))As part of this change, stop doing
str(Path)casts everywhere it's done for this reason.This is an automatic backport of pull request #873 done by Mergify.