Skip to content

quadlet: do not set RemainAfterExit=yes for volume units by default #29375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahajan-Sachin wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

quadlet: do not set RemainAfterExit=yes for volume units by default #29375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/systemd/quadlet/quadlet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ func ConvertVolume(volume *parser.UnitFile, unitsInfoMap map[string]*UnitInfo, i

service.AddCmdline(ServiceGroup, "ExecStart", podman.Args)

defaultOneshotServiceGroup(service, true)
defaultOneshotServiceGroup(service, false)

// Store the name of the created resource
unitInfo.ResourceName = volumeName
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/quadlet/basic.volume
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## assert-key-is Unit RequiresMountsFor "%t/containers"
## assert-key-is Service Type oneshot
## assert-key-is Service RemainAfterExit yes
## !assert-key-is Service RemainAfterExit yes
## assert-key-is-regex Service ExecStart ".*/podman volume create --ignore systemd-basic"
## assert-key-is Service SyslogIdentifier "%N"

Expand Down