quadlet: do not set RemainAfterExit=yes for volume units by default - #29375
Open
Mahajan-Sachin wants to merge 1 commit into
Open
quadlet: do not set RemainAfterExit=yes for volume units by default#29375Mahajan-Sachin wants to merge 1 commit into
Mahajan-Sachin wants to merge 1 commit into
Conversation
Ref podman-container-tools#27866 Do not set RemainAfterExit=yes by default when converting Quadlet .volume files to systemd oneshot services. Setting RemainAfterExit=yes causes systemd to consider the volume service active even after the volume is deleted manually, preventing systemd from re-executing volume creation when dependent container services restart. Signed-off-by: Sachin Mahajan <sachinmahajan903@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #27862
Summary
Quadlet previously set
RemainAfterExit=yesby default when converting.volumeunit files into systemd oneshot services.Because
RemainAfterExit=yeskeeps the service unit in theactive (exited)state, if a volume is deleted (e.g. to update volume options) and a dependent container service is restarted, systemd skips re-executing the volume service since it is already marked active.Changes
ConvertVolume()inpkg/systemd/quadlet/quadlet.goto passfalseforremainAfterExit.test/e2e/quadlet/basic.volume.Checklist
git commit -s)