Fix: adjust README image paths in packages/volto after copy during re… #7440
Conversation
|
@aryan7081 thanks for your contribution! Would you please add a Change log entry? Also would you please update this branch with Then we can review. |
|
@stevepiercy I have added the change log entry and updated the branch with main. |
There was a problem hiding this comment.
Revert this changes to this file. It's not related to the purpose of this PR.
For updating your branch against main, see https://6.docs.plone.org/contributing/first-time.html#update-your-pull-request-from-your-fork
|
@stevepiercy I have reverted the unrelated changes |
There was a problem hiding this comment.
This LGTM, with the one amendment to the change log entry.
We'll need our release manager @sneridagh to review and test it out to ensure it does what we expect. Thank you!
| @@ -0,0 +1 @@ | |||
| Adjust README logo paths in packages/volto after copying from top-level README to prevent CI link-check failures. @aryan7081 | |||
There was a problem hiding this comment.
| Adjust README logo paths in packages/volto after copying from top-level README to prevent CI link-check failures. @aryan7081 | |
| Adjust logo paths in `packages/volto/README.md` after copying it from the top-level `README.md` to prevent CI link check failures. @aryan7081 |
|
@aryan7081 also can you edit your initial description from |
|
@stevepiercy I have updated the description from ref |
Fixes #7437
The release process copies the root README.md into https://github.com/plone/volto/blob/main/packages/volto/, leaving broken logo image paths
docs/logos/...This fix updates the
after: bumphook in https://github.com/plone/volto/blob/main/packages/volto/.release-it.json to run a sed replacement, ensuring the paths become../../docs/logos/..., which allows logos to display correctly and the CI link checker to pass.