Fixed issue of merging block contents upon pressing backspace at start of second block with some content

[aryan7081]

Ref #7263

Inside the joinWithPreviousBlock function of packages/volto-slate/src/blocks/Text/keyboard/joinBlocks.js, pressing Backspace (Delete on mac) at the start of a block incorrectly merged the previous block's content into the current block, instead of merging the current block into previous one.

This happened because the implementation relied on mergeSlateWithBlockBackward(editor, otherBlock) which altered the current block's editor slate causing the wrong merge direction.

This fix removes the dependency and explicitly appends the current block's children (editor.children) into the previous block's value, then deletes the current block.

[wesleybl]

This adds a new line to the previous paragraph. The expectation here is that the second paragraph will be added to the end of the previous paragraph, without adding a new line.

[aryan7081]

@wesleybl Thanks for pointing this out. It is fixed in the latest commit. Now merging happens Inline without adding a new line.

[wesleybl]

After the merge, the cursor must be before the first character of the second paragraph.

[aryan7081]

Fixed, the Cursor is now placed before the first character of the second paragraph.

[wesleybl]

Please add a Changes entry: https://6.docs.plone.org/volto/contributing/index.html#change-log-entry

and fix the lint errors: https://6.docs.plone.org/volto/contributing/linting.html#linting

[wesleybl]

When I press Backspace and then Enter, the content that was originally in the second paragraph remains in the first paragraph.

[aryan7081]

@wesleybl PR updated:

• Pressing Enter at the merge point now correctly splits into a new block.
• Fixed linting issues.
• Added the required changelog entry, but Git/Towncrier is not detecting the file. Could you advise on what might be missing?

[davisagli]

@aryan7081 You also need a changelog file in packages/volto/news since you added the cypress test there. Use the extension .internal for that one since the change there is not a user-facing change.

[aryan7081]

@davisagli Thanks for the guidance! I’ve added the internal changelog for the Cypress test.

[wesleybl]

I positioned the cursor before the first character of a paragraph. Then I pressed Enter several times. When I press backspace once, it removed the previous block. But after that, I had to press backspace twice to remove the remaining blocks.

[wesleybl]

We generally do not put the author's name in parentheses.

[aryan7081]

@wesleybl I have removed the author's name from the changelog entry and fixed the issue of pressing backspace twice to remove the remaining blocks.

[wesleybl]

Please add your username in the note.

[wesleybl]

Why weren't the changes made to mergeSlateWithBlockBackward? Have you considered whether the code there is needed? Even if it isn't needed, the implementation can be done there to make the code more modular and separate. mergeSlateWithBlockBackward is only used here.

[wesleybl]

Please add your username in the note.

[aryan7081]

@wesleybl Thanks, I investigated and found that mergeSlateWithBlockBackward wasn't being used anywhere, so I fixed the bug in that function. Now, joinWithPreviousBlock uses it instead of duplicating custom logic. Also, I have added the username to the log files.

[wesleybl]

Don't use barrel import. Remove this line and import the full path.

[aryan7081]

@wesleybl I have replaced barrel import with direct module import.

[wesleybl]

LGTM

[aryan7081]

@wesleybl May I know the reason why you have edited the pr description from Fixes #7263 to Ref #7623? See https://6.docs.plone.org/contributing/first-time.html#create-a-pull-request-from-your-fork item #2. Thank you!

[wesleybl]

@aryan7081 It's because this PR doesn't fix #7263. They are similar but not the same situations.

[aryan7081]

@wesleybl Okay, got it. Thanks for the clarification.