Skip to content

fix: avoid nil cursor on callback errors#78

Closed
nickvanw wants to merge 2 commits into
mainfrom
fix/delete-update-error-cursor
Closed

fix: avoid nil cursor on callback errors#78
nickvanw wants to merge 2 commits into
mainfrom
fix/delete-update-error-cursor

Conversation

@nickvanw

@nickvanw nickvanw commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return the current cursor instead of nil when delete serialization callbacks fail
  • return the current cursor instead of nil when update serialization callbacks fail
  • add regression coverage that these callback failures do not panic in Read

Testing

  • GOCACHE=/tmp/fivetran-go-build go test ./lib (fails before tests run: link: vitess.io/vitess/go/hack: invalid reference to runtime.roundupsize)

@nickvanw nickvanw force-pushed the fix/delete-update-error-cursor branch from 3b86a0f to f080298 Compare June 15, 2026 19:04
@nickvanw nickvanw force-pushed the fix/delete-update-error-cursor branch from 8411c6c to d71f204 Compare June 15, 2026 20:52
@nickvanw

Copy link
Copy Markdown
Contributor Author

Closing in favor of #89, which folds this cursor-safety fix into a single non-stacked PR with the read-error propagation and VStream schema guidance.

@nickvanw nickvanw closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants