Return non-timeout read errors#87
Closed
nickvanw wants to merge 1 commit into
Closed
Conversation
b0dcff0 to
f8c670b
Compare
f8c670b to
de845ed
Compare
This was referenced Jun 16, 2026
maxenglander
approved these changes
Jun 16, 2026
Contributor
Author
|
Closing in favor of #89, which folds the non-timeout read-error propagation into a single non-stacked PR with the cursor-safety fix and VStream schema guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
The live bugbash BIT test against PlanetScale hit a local serializer error: "unable to serialize row: failed to serialize DataType_LONG". connectClient.Read logged the Internal error but returned a nil error with a cursor, so Sync.Handle treated the failed row sync as successful and only emitted the truncate/checkpoint path. That can hide data serialization failures and checkpoint past rows that were not emitted.
Relationship to #78
#78 fixes which cursor is returned when callbacks fail. This PR fixes whether the callback error is returned at all. The two changes merge cleanly.
Validation