Skip to content

fix(mobile): remove redundant search bar insets #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skjiisa wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −17
Open

fix(mobile): remove redundant search bar insets #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions patches/react-native-screens@4.25.2.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ index 5970e3e3a624b9498b8dedfc16831df03a274d0c..073a72a68688369f39e54b61d1381b8d
+ searchField.translatesAutoresizingMaskIntoConstraints = NO;
+ [glassView.contentView addSubview:searchField];
+ [NSLayoutConstraint activateConstraints:@[
+ [searchField.leadingAnchor constraintEqualToAnchor:glassView.contentView.leadingAnchor constant:14.0],
+ [searchField.trailingAnchor constraintEqualToAnchor:glassView.contentView.trailingAnchor constant:-14.0],
+ [searchField.leadingAnchor constraintEqualToAnchor:glassView.contentView.leadingAnchor constant:1.0],
+ [searchField.trailingAnchor constraintEqualToAnchor:glassView.contentView.trailingAnchor constant:1.0],

@cursor cursor Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing constraint sign inverted

Medium Severity

The searchField's trailing constraint uses constant:1.0, which incorrectly pushes its trailing edge outside glassView.contentView. Unlike the previous -14.0 or parallel -8.0 values, this results in asymmetric horizontal padding and may cause content to clip.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dce3c2b. Configure here.

+ [searchField.centerYAnchor constraintEqualToAnchor:glassView.contentView.centerYAnchor],
+ [searchField.heightAnchor constraintEqualToConstant:searchFieldHeight],
+ ]];
Expand Down
30 changes: 15 additions & 15 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading