Skip to content

fix(mobile): remove redundant search bar insets - #4907

Open
skjiisa wants to merge 1 commit into
pingdotgg:mainfrom
skjiisa:feature/fix/screens-search-field-inset
Open

fix(mobile): remove redundant search bar insets#4907
skjiisa wants to merge 1 commit into
pingdotgg:mainfrom
skjiisa:feature/fix/screens-search-field-inset

Conversation

@skjiisa

@skjiisa skjiisa commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What Changed

Updated the react-native-screens patch so the native search field's leading/trailing constraints use a 1.0pt constant instead of 14.0pt (what looked best to me), removing a redundant inset that was doubling up with existing padding. Bumped the patch hash and refreshed pnpm-lock.yaml accordingly.

Why

The search bar in the glass header had extra horizontal inset baked into the native patch on top of insets already applied elsewhere, making the search field appear narrower than intended.

UI Changes

Before

Simulator Screenshot - iPhone 17 Pro - 2026-07-29 at 22 14 51 copy

After

Simulator Screenshot - iPhone 17 Pro - 2026-07-29 at 21 41 01 copy

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Visual/layout-only change in a patched iOS native constraint; no auth, data, or business-logic impact.

Overview
Tightens horizontal layout for the fallback native search field inside the glass mail-search toolbar by changing its leading/trailing layout constraints from 14pt to 1pt, so the field is not inset twice alongside other padding.

The react-native-screens patch hash is updated and pnpm-lock.yaml is refreshed so installs pick up the revised patch.

Reviewed by Cursor Bugbot for commit dce3c2b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove redundant horizontal insets from mobile search bar

Patches react-native-screens to reduce the leading and trailing anchor constants for the search field from 14.0pt to 1.0pt, removing the extra horizontal padding inside the glass view's content view. Applied via patches/react-native-screens@4.25.2.patch.

Macroscope summarized dce3c2b.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62ce3b63-c964-4a57-8fe0-d713dbf86831

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 30, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dce3c2b. Configure here.

+ [searchField.leadingAnchor constraintEqualToAnchor:glassView.contentView.leadingAnchor constant:14.0],
+ [searchField.trailingAnchor constraintEqualToAnchor:glassView.contentView.trailingAnchor constant:-14.0],
+ [searchField.leadingAnchor constraintEqualToAnchor:glassView.contentView.leadingAnchor constant:1.0],
+ [searchField.trailingAnchor constraintEqualToAnchor:glassView.contentView.trailingAnchor constant:1.0],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing constraint sign inverted

Medium Severity

The searchField's trailing constraint uses constant:1.0, which incorrectly pushes its trailing edge outside glassView.contentView. Unlike the previous -14.0 or parallel -8.0 values, this results in asymmetric horizontal padding and may cause content to clip.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dce3c2b. Configure here.

@macroscopeapp

macroscopeapp Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

An unresolved review comment identifies a potential bug: the trailing constraint constant should likely be -1.0, not +1.0, per iOS Auto Layout conventions. This could cause the search field to extend outside its container. Human verification is recommended.

You can customize Macroscope's approvability policy. Learn more.

@skjiisa

skjiisa commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

The potential issue flagged is intentional for the sake of optical alignment based on real app screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant