Skip to content

feat: make kratos-selfservice-ui-node probes configurable #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobbyiliev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: make kratos-selfservice-ui-node probes configurable #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/charts/kratos-selfservice-ui-node/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ apiVersion: v2
appVersion: "v0.13.0-4"
description: A Helm chart for ORY Kratos's example ui for Kubernetes
name: kratos-selfservice-ui-node
version: 0.61.1
version: 0.61.2
type: application
4 changes: 3 additions & 1 deletion helm/charts/kratos-selfservice-ui-node/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# kratos-selfservice-ui-node

![Version: 0.61.1](https://img.shields.io/badge/Version-0.61.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.13.0-4](https://img.shields.io/badge/AppVersion-v0.13.0--4-informational?style=flat-square)
![Version: 0.61.2](https://img.shields.io/badge/Version-0.61.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.13.0-4](https://img.shields.io/badge/AppVersion-v0.13.0--4-informational?style=flat-square)

A Helm chart for ORY Kratos's example ui for Kubernetes

Expand All @@ -14,6 +14,8 @@ A Helm chart for ORY Kratos's example ui for Kubernetes
| config.secrets | object | `{}` | |
| deployment.annotations | object | `{}` | |
| deployment.automountServiceAccountToken | bool | `false` | |
| deployment.customLivenessProbe | object | `{}` | Provide a full override of the liveness probe. Useful when the UI is serving HTTPS (e.g. via TLS_CERT_PATH / TLS_KEY_PATH) and the default HTTP probe needs to be replaced with an HTTPS one, or when a custom tcpSocket/exec probe is required. |
| deployment.customReadinessProbe | object | `{}` | Provide a full override of the readiness probe. See customLivenessProbe for when to use this. |
| deployment.dnsConfig | object | `{}` | Configure pod dnsConfig. |
| deployment.extraEnv | list | `[]` | Array of extra envs to be passed to the deployment. Kubernetes format is expected - name: FOO value: BAR |
| deployment.extraVolumeMounts | list | `[]` | |
Expand Down
10 changes: 10 additions & 0 deletions helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,24 @@ spec:
- name: http
containerPort: 3000
protocol: TCP
{{- if .Values.deployment.customLivenessProbe }}
livenessProbe:
{{- toYaml .Values.deployment.customLivenessProbe | nindent 12 }}
{{- else }}
livenessProbe:
httpGet:
path: {{ .Values.basePath }}/health/alive
port: http
{{- end }}
{{- if .Values.deployment.customReadinessProbe }}
readinessProbe:
{{- toYaml .Values.deployment.customReadinessProbe | nindent 12 }}
{{- else }}
readinessProbe:
httpGet:
path: {{ .Values.basePath }}/health/ready
port: http
{{- end }}
resources:
{{- toYaml .Values.deployment.resources | nindent 12 }}
{{- if .Values.securityContext }}
Expand Down
24 changes: 24 additions & 0 deletions helm/charts/kratos-selfservice-ui-node/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,30 @@ deployment:
automountServiceAccountToken: false
terminationGracePeriodSeconds: 60

# -- Provide a full override of the liveness probe. Useful when the UI is
# serving HTTPS (e.g. via TLS_CERT_PATH / TLS_KEY_PATH) and the default
# HTTP probe needs to be replaced with an HTTPS one, or when a custom
# tcpSocket/exec probe is required.
customLivenessProbe: {}
# customLivenessProbe:
# httpGet:
# path: /health/alive
# port: http
# scheme: HTTPS
# initialDelaySeconds: 5
# periodSeconds: 10

# -- Provide a full override of the readiness probe. See customLivenessProbe
# for when to use this.
customReadinessProbe: {}
# customReadinessProbe:
# httpGet:
# path: /health/ready
# port: http
# scheme: HTTPS
# initialDelaySeconds: 3
# periodSeconds: 5

affinity: {}

# -- Set this to ORY Kratos's Admin URL
Expand Down
Loading