feat: make kratos-selfservice-ui-node probes configurable

[bobbyiliev]

Description

The UI supports HTTPS via TLS_CERT_PATH / TLS_KEY_PATH, but the chart's probes are hardcoded HTTP, so the pod crash-loops once TLS is turned on.

This adds deployment.customLivenessProbe and deployment.customReadinessProbe, same pattern as the kratos chart (deployment-kratos.yaml). Both default to {}, so existing deployments are unchanged.

Verified with helm lint and helm template in default and override modes.

Checklist

• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
• I have added the necessary documentation within the code base (values.yaml + regenerated README via helm-docs).
• I have added tests that prove my fix is effective or that my feature works.

Summary by CodeRabbit

• New Features

  • Custom Kubernetes health probe configurations (liveness and readiness checks) are now supported, enabling advanced deployment scenarios including HTTPS-based health monitoring and customized probe timing, while maintaining backward compatibility with default HTTP probes.

• Chores

  • Helm chart version updated to 0.61.2.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

📝 Walkthrough

Walkthrough

Helm chart version is bumped from 0.61.1 to 0.61.2, and optional custom liveness and readiness probe configurations are added to allow users to override default HTTP probe definitions with custom implementations.

Changes

Cohort / File(s)	Summary
Chart metadata and documentation helm/charts/kratos-selfservice-ui-node/Chart.yaml, helm/charts/kratos-selfservice-ui-node/README.md	Version updated to 0.61.2 in chart metadata and documentation badge. README now documents new deployment.customLivenessProbe and deployment.customReadinessProbe configuration options.
Custom probe support helm/charts/kratos-selfservice-ui-node/values.yaml, helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml	Added deployment.customLivenessProbe and deployment.customReadinessProbe values (defaulting to {}), with sample HTTPS configurations included. Deployment template now conditionally renders custom probes when provided, otherwise uses default HTTP health check endpoints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description is largely complete, explaining the motivation (HTTPS/TLS support), implementation approach (following kratos chart pattern), and verification steps; however, the template's 'Related Issue or Design Document' section is not addressed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: adding configurable probes to the kratos-selfservice-ui-node Helm chart.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adds configurable Kubernetes probes to the kratos-selfservice-ui-node Helm chart so deployments using HTTPS (via TLS_CERT_PATH / TLS_KEY_PATH) can replace the default HTTP probes and avoid crash loops.

Changes:

• Introduces deployment.customLivenessProbe and deployment.customReadinessProbe values (default {}) to fully override the probes.
• Updates the Deployment template to use the custom probes when provided, otherwise keeps existing HTTP probe behavior.
• Bumps chart version and regenerates README values documentation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
helm/charts/kratos-selfservice-ui-node/values.yaml	Adds new customLivenessProbe / customReadinessProbe values with documentation and examples.
helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml	Conditionally renders custom probes when non-empty, preserving defaults otherwise.
helm/charts/kratos-selfservice-ui-node/README.md	Updates chart version badge and documents new values (helm-docs output).
helm/charts/kratos-selfservice-ui-node/Chart.yaml	Bumps chart version from 0.61.1 to 0.61.2.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

🧹 Nitpick comments (1)

helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml (1)

88-105: Add template regression coverage for both branches.

Given these are conditional render paths, adding chart tests (default probe path + custom probe path) would reduce risk of future template regressions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml` around
lines 88 - 105, Add chart tests that exercise both conditional branches in the
deployment template for liveness/readiness probes: write one test that renders
the template with no deployment.customLivenessProbe/customReadinessProbe set and
asserts the rendered container has httpGet probes using {{ .Values.basePath
}}/health/alive and /health/ready (and port named "http"), and a second test
that supplies deployment.customLivenessProbe and deployment.customReadinessProbe
values and asserts the rendered YAML contains the custom probe fields (e.g., the
full toYaml output you expect). Target the Helm template named in the diff
(deployment.yaml) and use your chart-testing framework (helm unittest or
chart-testing) to render and assert both the default-path branch and the
custom-probe branch to prevent regressions.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml`:
- Around line 88-105: Add chart tests that exercise both conditional branches in
the deployment template for liveness/readiness probes: write one test that
renders the template with no deployment.customLivenessProbe/customReadinessProbe
set and asserts the rendered container has httpGet probes using {{
.Values.basePath }}/health/alive and /health/ready (and port named "http"), and
a second test that supplies deployment.customLivenessProbe and
deployment.customReadinessProbe values and asserts the rendered YAML contains
the custom probe fields (e.g., the full toYaml output you expect). Target the
Helm template named in the diff (deployment.yaml) and use your chart-testing
framework (helm unittest or chart-testing) to render and assert both the
default-path branch and the custom-probe branch to prevent regressions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d369d0fd-5623-45c2-be5c-ade6c799a75b

📥 Commits

Reviewing files that changed from the base of the PR and between bd5cdce and df8983b.

📒 Files selected for processing (4)

• helm/charts/kratos-selfservice-ui-node/Chart.yaml
• helm/charts/kratos-selfservice-ui-node/README.md
• helm/charts/kratos-selfservice-ui-node/templates/deployment.yaml
• helm/charts/kratos-selfservice-ui-node/values.yaml