Fixed deallocate/2 to not add unknown/unallocated frequencies back to Free list#2
Open
derek121 wants to merge 2 commits intooreillymedia:masterfrom
Open
Fixed deallocate/2 to not add unknown/unallocated frequencies back to Free list#2derek121 wants to merge 2 commits intooreillymedia:masterfrom
derek121 wants to merge 2 commits intooreillymedia:masterfrom
Conversation
frequencies if it had actually appeared in Allocated. Previously, if a frequency was passed to deallocate/2 that didn't actually appear in Allocated, it would still be added into the Free list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From commit msg:
Changed deallocate/2 to only add Freq back to the list of free frequencies if
it had actually appeared in Allocated. Previously, if a frequency was passed to
deallocate/2 that didn't actually appear in Allocated, it would still be added
into the Free list.