Validate frequency being deallocated#1
Closed
derek121 wants to merge 1 commit intofrancescoc:masterfrom
Closed
Conversation
Don't add Freq to Free if it wasn't actually in Allocated. Alternatively, could be stricter and fail rather than silently ignoring.
Owner
|
We do this only for the Error handling section when a race condition can occur after linking to the client process.If the process terminates, we check if a frequency is associated to this process. If so, it is freed. Race conditions can happen, as the process can free the frequency and then terminate before the server handles the request. The case you suggest is as a result of a corrupt state. We decided not to handle all of these border line cases, as they would have made the example more complicated, loosing focus on what we were trying to explain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't add Freq to Free if it wasn't actually in Allocated.
Alternatively, could be stricter and fail rather than silently ignoring.
I'd submitted a PR to the O'Reilly repo a while back, and was reminded of it by your tweet today