Fix DIF holder presentation signing for did:key - #4196
Conversation
Fixes openwallet-foundation#4195 by preserving explicit issuer_id, honoring explicit holder signing DIDs, improving automatic did:key discovery, and failing clearly when holder signing cannot determine a local DID. Signed-off-by: jacksonriding <jackson.riding@gmail.com>
580c4c9 to
a5ac02b
Compare
|
Forgot to sign :P |
|
The two failing tests look real -- could you @jacksonriding take a look at them? The ruff one should be trivial, but not sure about the PR Tests -- certainly seems to be in the area that you are updating. @jacksonriding -- I'm assuming that once this PR is merged, it should be cherry-picked and applied to the 1.6.lts and 1.3.lts branches as well? Are you able to do that or should I plan to do it? |
Signed-off-by: Jackson Riding <jackson.riding@gmail.com>
|
Thanks @swcurran. I tracked down and fixed both failures. Ruff was a formatting issue in the new test. The PR test DIF suite now passes all tests with BBS. Ruff also passes. Will look into backporting 1.6 and 1.3 lts after merge |
|



Fixes #4195.
Preserves explicit issuer_id when the original presentation definition is reused; honors explicit pres_signing_did before holder auto-detection; skips non-local subject DIDs while discovering a local did:key; and fails explicitly when holder signing cannot determine a local DID instead of returning an unsigned VP.
Validation: 74 affected DIF tests passed, 46 optional BBS tests skipped; Ruff passed; git diff --check passed.