fix: backport DIF holder presentation signing to 1.6 LTS - #4217
Merged
swcurran merged 1 commit intoSep 9, 2026
Merged
Conversation
Backport of openwallet-foundation#4196, merge commit c148063. Includes the complete production fix and regression tests. Signed-off-by: Jackson Riding <jackson.riding@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #4196 to
1.6.lts, as requested in #4196 (comment).Preserves an explicit
issuer_idwhen reusing the requested presentation definition, honors an explicitpres_signing_didin holder mode, and skips non-local subject DIDs during local signing-key discovery. Holder mode now raisesDIFPresExchErrorwhen no local signing DID is available, instead of returning an unsigned presentation.The four-file patch is identical to the net change in merge commit c148063 (matching stable patch ID), including the corrected regression tests. No dependency or unrelated main-branch changes are included.
Validation on Python 3.13, using this LTS branch's locked dependencies