Skip to content

SREP-4236: Add pr-check presubmit to openshift/managed-cluster-validating-webhooks#77097

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
reedcort:SREP-4236-mcvw-config-pr-check
Mar 31, 2026
Merged

SREP-4236: Add pr-check presubmit to openshift/managed-cluster-validating-webhooks#77097
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
reedcort:SREP-4236-mcvw-config-pr-check

Conversation

@reedcort
Copy link
Copy Markdown
Contributor

@reedcort reedcort commented Mar 30, 2026

Summary

  • Adds a pr-check presubmit that runs hack/prow_pr_check.sh from the src container
  • Removes base_images and images sections (image builds handled by Konflux/Tekton)
  • Keeps image_stream_tag as build_root since the repo's Dockerfile is a multi-stage build without Go in the final image

Context

Migrates the pr-check from app-interface Jenkins to Prow (SREP-4236).

Depends on: openshift/managed-cluster-validating-webhooks#484

Test plan

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@reedcort: This pull request references SREP-4236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a pr-check presubmit that runs hack/prow_pr_check.sh from the src container
  • Removes base_images and images sections (image builds handled by Konflux/Tekton)
  • Keeps image_stream_tag as build_root since the repo's Dockerfile is a multi-stage build without Go in the final image

Context

Migrates the pr-check from app-interface Jenkins to Prow (SREP-4236).

Depends on: openshift/managed-cluster-validating-webhooks#484

Test plan

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from diakovnec and nephomaniac March 30, 2026 18:00
@reedcort
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@reedcort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@reedcort
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@reedcort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

…ting-webhooks

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@reedcort reedcort force-pushed the SREP-4236-mcvw-config-pr-check branch from 02e8206 to 4c5cb5d Compare March 31, 2026 14:34
@reedcort
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@reedcort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@reedcort: This pull request references SREP-4236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a pr-check presubmit that runs hack/prow_pr_check.sh from the src container
  • Removes base_images and images sections (image builds handled by Konflux/Tekton)
  • Keeps image_stream_tag as build_root since the repo's Dockerfile is a multi-stage build without Go in the final image

Context

Migrates the pr-check from app-interface Jenkins to Prow (SREP-4236).

Depends on: openshift/managed-cluster-validating-webhooks#484

Test plan

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@reedcort: This pull request references SREP-4236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a pr-check presubmit that runs hack/prow_pr_check.sh from the src container
  • Removes base_images and images sections (image builds handled by Konflux/Tekton)
  • Keeps image_stream_tag as build_root since the repo's Dockerfile is a multi-stage build without Go in the final image

Context

Migrates the pr-check from app-interface Jenkins to Prow (SREP-4236).

Depends on: openshift/managed-cluster-validating-webhooks#484

Test plan

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@reedcort
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-managed-cluster-validating-webhooks-master-pr-check

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@reedcort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joshbranham
Copy link
Copy Markdown
Contributor

/lgtm
/approve
/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joshbranham: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 31, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 185e43f into openshift:main Mar 31, 2026
17 checks passed
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 2, 2026
…ting-webhooks (openshift#77097)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants