SREP-4236: Fix GOFLAGS and regenerate package resources by reedcort · Pull Request #485 · openshift/managed-cluster-validating-webhooks

reedcort · 2026-03-30T18:43:43Z

Summary

Sets GOFLAGS=-mod=mod in hack/prow_pr_check.sh to fix Prow pr-check failure
Regenerates stale config/package/resources.yaml.gotmpl to include sre-network-operator-validation webhook

Context

The Prow environment sets GOFLAGS=-mod=vendor by default, which conflicts with this repo's module-based setup. The Makefile already handles this with unexport GOFLAGS (line 29), but the new prow_pr_check.sh script was missing the equivalent.

Fixes the pr-check failure in openshift/release#77097.

Test plan

Verified locally: GOFLAGS=-mod=vendor bash hack/prow_pr_check.sh now passes

🤖 Generated with Claude Code

Prow sets GOFLAGS=-mod=vendor which conflicts with this repo's module-based setup. Unset and re-export with -mod=mod to match the Makefile behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-03-30T18:43:48Z

@reedcort: This pull request references SREP-4236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Sets GOFLAGS=-mod=mod in hack/prow_pr_check.sh to fix Prow pr-check failure

Regenerates stale config/package/resources.yaml.gotmpl to include sre-network-operator-validation webhook

Context

The Prow environment sets GOFLAGS=-mod=vendor by default, which conflicts with this repo's module-based setup. The Makefile already handles this with unexport GOFLAGS (line 29), but the new prow_pr_check.sh script was missing the equivalent.

Fixes the pr-check failure in openshift/release#77097.

Test plan

Verified locally: GOFLAGS=-mod=vendor bash hack/prow_pr_check.sh now passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-30T18:43:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee586773-30b5-41fb-a5bc-59f0a72be822

📥 Commits

Reviewing files that changed from the base of the PR and between 76d548c and 562ff10.

📒 Files selected for processing (2)

config/package/resources.yaml.gotmpl
hack/prow_pr_check.sh

Walkthrough

Added a ValidatingWebhookConfiguration resource for network resource validation and updated a test script to explicitly set Go build module flags for test execution.

Changes

Cohort / File(s)	Summary
Kubernetes Configuration `config/package/resources.yaml.gotmpl`	Added new `ValidatingWebhookConfiguration` named `sre-network-operator-validation` for validating `network` resources in `operator.openshift.io` on UPDATE events with standard webhook configuration (failurePolicy: Ignore, timeoutSeconds: 2, caBundle templating).
Build Script Enhancement `hack/prow_pr_check.sh`	Modified test script to explicitly override `GOFLAGS` environment variable, unsetting existing values and setting `-mod=mod` to ensure module-based builds for test execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-30T18:51:27Z

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

reedcort · 2026-03-30T20:26:18Z

/hold

reedcort · 2026-03-31T14:33:54Z

/retest

reedcort · 2026-03-31T14:37:08Z

/unhold

joshbranham · 2026-03-31T14:57:16Z

/lgtm
/approve

openshift-ci · 2026-03-31T14:58:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SREP-4236: Fix GOFLAGS in prow_pr_check.sh

562ff10

Prow sets GOFLAGS=-mod=vendor which conflicts with this repo's module-based setup. Unset and re-export with -mod=mod to match the Makefile behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2026

openshift-ci bot requested review from anispate and smarthall March 30, 2026 18:44

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026

openshift-ci bot assigned joshbranham Mar 31, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026

openshift-merge-bot bot merged commit 4c87973 into openshift:master Mar 31, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SREP-4236: Fix GOFLAGS and regenerate package resources#485

SREP-4236: Fix GOFLAGS and regenerate package resources#485
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
reedcort:SREP-4236-fix-goflags

reedcort commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026 •

edited by atlassian bot

Loading

Summary

Context

Test plan

Uh oh!

coderabbitai bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

reedcort commented Mar 30, 2026

Uh oh!

reedcort commented Mar 31, 2026

Uh oh!

reedcort commented Mar 31, 2026

Uh oh!

joshbranham commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

reedcort commented Mar 30, 2026

Summary

Context

Test plan

Uh oh!

openshift-ci-robot commented Mar 30, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Test plan

Uh oh!

coderabbitai bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

reedcort commented Mar 30, 2026

Uh oh!

reedcort commented Mar 31, 2026

Uh oh!

reedcort commented Mar 31, 2026

Uh oh!

joshbranham commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openshift-ci-robot commented Mar 30, 2026 •

edited by atlassian bot

Loading

coderabbitai bot commented Mar 30, 2026 •

edited

Loading