OCPBUGS-77689: Create admin-ack gates for azure/vsphere clusters upgrading to 4.22#5735
Conversation
|
Skipping CI for Draft Pull Request. |
|
@djoshy: This pull request references Jira Issue OCPBUGS-77689, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@djoshy: This pull request references Jira Issue OCPBUGS-77689, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@djoshy: This pull request references Jira Issue OCPBUGS-77689, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@djoshy: This pull request references Jira Issue OCPBUGS-77689, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b26c64b to
dd3f0b3
Compare
|
/retest |
dd3f0b3 to
2c026c6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
Pre-merge tested: Environment Setup Steps
$ oc get clusterversion version -o jsonpath='{.status.conditions[?(@.type=="Upgradeable")]}'
{"lastTransitionTime":"2026-03-06T02:30:24Z","message":"This cluster is Azure or vSphere but lacks a boot image configuration. OCP will automatically opt this cluster into boot image management in 4.22. Please add a configuration to disable boot image updates if this is not desired. See https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html/machine_configuration/mco-update-boot-images#mco-update-boot-images-disable_machine-configs-configure for more details.","reason":"AdminAckRequired","status":"False","type":"Upgradeable"}
$ oc edit cm admin-acks -n openshift-config -o yaml
apiVersion: v1
data:
ack-4.21-boot-image-opt-out-in-4.22: "true"
kind: ConfigMap
metadata:
annotations:
include.release.openshift.io/hypershift: "true"
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
kubernetes.io/description: Record administrator acknowledgments of update gates
defined in the admin-gates ConfigMap in the openshift-config-managed namespace.
release.openshift.io/create-only: "true"
creationTimestamp: "2026-03-06T02:30:55Z"
name: admin-acks
namespace: openshift-config
resourceVersion: "49973"
uid: fbad92d1-73a0-4184-8153-cc83eb726224
$ oc get clusterversion version -o jsonpath='{.status.conditions[?(@.type=="Upgradeable")]}'
empty
data:
ack-4.21-boot-image-opt-out-in-4.22: "false"
$ oc get clusterversion version -o jsonpath='{.status.conditions[?(@.type=="Upgradeable")]}'
{"lastTransitionTime":"2026-03-06T04:15:02Z","message":"This cluster is Azure or vSphere but lacks a boot image configuration. OCP will automatically opt this cluster into boot image management in 4.22. Please add a configuration to disable boot image updates if this is not desired. See https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html/machine_configuration/mco-update-boot-images#mco-update-boot-images-disable_machine-configs-configure for more details.","reason":"AdminAckRequired","status":"False","type":"Upgradeable"}
managedBootImages:
machineManagers:
- apiGroup: machine.openshift.io
resource: machinesets
selection:
mode: All
$ oc get clusterversion version -o jsonpath='{.status.conditions[?(@.type=="Upgradeable")]}'
empty
$ oc get clusterversion version -o jsonpath='{.status.conditions[?(@.type=="Upgradeable")]}'
{"lastTransitionTime":"2026-03-06T04:15:02Z","message":"This cluster is Azure or vSphere but lacks a boot image configuration. OCP will automatically opt this cluster into boot image management in 4.22. Please add a configuration to disable boot image updates if this is not desired. See https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html/machine_configuration/mco-update-boot-images#mco-update-boot-images-disable_machine-configs-configure for more details.","reason":"AdminAckRequired","status":"False","type":"Upgradeable"}/label qe-approved |
|
@djoshy: This pull request references Jira Issue OCPBUGS-77689, which is valid. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ptalgulk01: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@djoshy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e72a311
into
openshift:release-4.21
|
@djoshy: Jira Issue OCPBUGS-77689: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-77689 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@djoshy: Jira Issue OCPBUGS-77689: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-77689 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@djoshy: Jira Issue Verification Checks: Jira Issue OCPBUGS-77689 Jira Issue OCPBUGS-77689 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Much of this PR is based on #5027 which landed directly in the
release-4.19branch. This PR adds a new admin-ack gate with the keyack-4.21-boot-image-opt-out-in-4.22when a Azure/vSphere cluster does not have a boot image configuration in 4.21.These gates are only relevant for upgrades to 4.22, so they will only need to exist in the MCO's
release-4.21branch.- How to verify it
Before testing, ensure that any non MCO keys in the
admin-gatesCM have been acknowledged. See the description of #5027 for an example of this. Then, follow the steps below:Upgradeable=False(check viaoc get clusterversion -o yaml). Now, add a boot image configuration - the CVO should no longer be settingUpgradeableto false.