Skip to content

8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE #28587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE #28587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,20 @@ setThreadLocalStorage(jthread thread, ThreadNode *node)

error = JVMTI_FUNC_PTR(gdata->jvmti,SetThreadLocalStorage)
(gdata->jvmti, thread, (void*)node);
if ( error == JVMTI_ERROR_THREAD_NOT_ALIVE && node == NULL) {
/* Just return. This can happen when clearing the TLS. */
return;
} else if ( error != JVMTI_ERROR_NONE ) {
/* The jthread object must be valid, so this must be a fatal error */
if (error == JVMTI_ERROR_THREAD_NOT_ALIVE) {
if (node == NULL) {
// Just return. This can happen when clearing the TLS.
return;
}
if (isVThread(thread)) {
// Just return. This can happen with a vthread that is running and we
// had to create a ThreadNode for it. By the time we get here, it may
// have already terminated.
return;
}
}
if (error != JVMTI_ERROR_NONE) {
// The jthread object must be valid, so this must be a fatal error.
EXIT_ERROR(error, "cannot set thread local storage");
}
}
Expand Down Expand Up @@ -251,9 +260,10 @@ findThread(ThreadList *list, jthread thread)
* Otherwise the thread should not be on the runningThreads.
*/
if ( !gdata->jvmtiCallBacksCleared ) {
/* The thread better not be on either list if the TLS lookup failed. */
// The thread better not be on the runningThreads list if the TLS lookup failed.
// It might be on the runningVThreads list because of how ThreadNodes for vthreads
// can be recreated just before terminating, so we don't check runningVThreads.
JDI_ASSERT(!nonTlsSearch(getEnv(), &runningThreads, thread));
JDI_ASSERT(!nonTlsSearch(getEnv(), &runningVThreads, thread));
} else {
/*
* Search the runningThreads and runningVThreads lists. The TLS lookup may have
Expand Down