8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE #28587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of asserts that are now being triggered after the changes for JDK-8282441 were introduced. I had already run into these asserts while working on JDK-8371380, and had already fixed them there. However, JDK-8371380 likely is not going to be pushed for JDK 26, so I have moved the fixes to this PR.
You can also find the fixes I moved over from JDK-8282441 here: https://github.com/openjdk/jdk/pull/28485/files#diff-65eb4035b1d9bb5ceaab430461cd782069fe88c0a7d0438964c041caf0aa5eec
Tested by running failed test case a few hundred times, and also all tier5 CI svc tests, which includes a lot of JDI related testing with virtual threads enabled. Also ran tier1 CI.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28587/head:pull/28587$ git checkout pull/28587Update a local copy of the PR:
$ git checkout pull/28587$ git pull https://git.openjdk.org/jdk.git pull/28587/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28587View PR using the GUI difftool:
$ git pr show -t 28587Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28587.diff
Using Webrev
Link to Webrev Comment