Skip to content

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 1, 2025

Fix a couple of asserts that are now being triggered after the changes for JDK-8282441 were introduced. I had already run into these asserts while working on JDK-8371380, and had already fixed them there. However, JDK-8371380 likely is not going to be pushed for JDK 26, so I have moved the fixes to this PR.

You can also find the fixes I moved over from JDK-8282441 here: https://github.com/openjdk/jdk/pull/28485/files#diff-65eb4035b1d9bb5ceaab430461cd782069fe88c0a7d0438964c041caf0aa5eec

Tested by running failed test case a few hundred times, and also all tier5 CI svc tests, which includes a lot of JDI related testing with virtual threads enabled. Also ran tier1 CI.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28587/head:pull/28587
$ git checkout pull/28587

Update a local copy of the PR:
$ git checkout pull/28587
$ git pull https://git.openjdk.org/jdk.git pull/28587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28587

View PR using the GUI difftool:
$ git pr show -t 28587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28587.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8372809 8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review serviceability [email protected]

Development

Successfully merging this pull request may close these issues.

1 participant