Skip to content

8319161: GC: Make TestParallelGCThreads use createTestJavaProcessBuilder #28566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −6
Open

8319161: GC: Make TestParallelGCThreads use createTestJavaProcessBuilder #28566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2014, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2014, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -26,6 +26,7 @@
/*
* @test TestParallelGCThreads
* @bug 8059527 8081382
* @requires vm.gc == null
* @summary Tests argument processing for ParallelGCThreads
* @library /test/lib
* @library /
Expand Down Expand Up @@ -56,18 +57,18 @@ public static void main(String args[]) throws Exception {
private static final String printFlagsFinalPattern = " *uint *" + flagName + " *:?= *(\\d+) *\\{product\\} *";

public static void testDefaultValue() throws Exception {
OutputAnalyzer output = GCArguments.executeLimitedTestJava(
OutputAnalyzer output = GCArguments.executeTestJava(
"-XX:+UnlockExperimentalVMOptions", "-XX:+PrintFlagsFinal", "-version");

String value = output.firstMatch(printFlagsFinalPattern, 1);

try {
Asserts.assertNotNull(value, "Couldn't find uint flag " + flagName);

Long longValue = new Long(value);
Long longValue = Long.valueOf(value);

// Sanity check that we got a non-zero value.
Asserts.assertNotEquals(longValue, "0");
Asserts.assertNotEquals(longValue, 0L);

output.shouldHaveExitValue(0);
} catch (Exception e) {
Expand All @@ -86,14 +87,17 @@ public static void testFlags() throws Exception {
if (GC.Parallel.isSupported()) {
supportedGC.add("Parallel");
}
if (GC.Z.isSupported()) {
supportedGC.add("Z");
}

if (supportedGC.isEmpty()) {
throw new SkippedException("Skipping test because none of G1/Parallel is supported.");
}

for (String gc : supportedGC) {
// Make sure the VM does not allow ParallelGCThreads set to 0
OutputAnalyzer output = GCArguments.executeLimitedTestJava(
OutputAnalyzer output = GCArguments.executeTestJava(
"-XX:+Use" + gc + "GC",
"-XX:ParallelGCThreads=0",
"-XX:+PrintFlagsFinal",
Expand Down Expand Up @@ -122,7 +126,7 @@ public static void testFlags() throws Exception {
}

public static long getParallelGCThreadCount(String... flags) throws Exception {
OutputAnalyzer output = GCArguments.executeLimitedTestJava(flags);
OutputAnalyzer output = GCArguments.executeTestJava(flags);
output.shouldHaveExitValue(0);
String stdout = output.getStdout();
return FlagsValue.getFlagLongValue("ParallelGCThreads", stdout);
Expand Down