8319161: GC: Make TestParallelGCThreads use createTestJavaProcessBuilder #28566
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change:
@requires vm.gc == null- this line is added to skip runs that use GC flags in test vm options. Allowing GC flags will result in VM initialization error ("Multiple garbage collectors selected").Testing:
HS Tiers 1 and 2
Ran with all flag combinations in CI
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28566/head:pull/28566$ git checkout pull/28566Update a local copy of the PR:
$ git checkout pull/28566$ git pull https://git.openjdk.org/jdk.git pull/28566/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28566View PR using the GUI difftool:
$ git pr show -t 28566Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28566.diff
Using Webrev
Link to Webrev Comment