-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371347: Move the ObjectMonitorTable to a separate new file #28565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8371347: Move the ObjectMonitorTable to a separate new file #28565
Conversation
|
👋 Welcome back fbredberg! A progress list of the required criteria for merging this PR into |
|
@fbredber This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I did not verify line by line :)
Thanks
coleenp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're able to hide more of the implementation in the cpp file it'll be less dramatic when you change it.
| #define SHARE_RUNTIME_OBJECTMONITORTABLE_HPP | ||
|
|
||
| class ObjectMonitorTable : AllStatic { | ||
| struct Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you hide all of this in the .cpp file like symbolTable.cpp hides the CHT implementation instead of having it all in the hpp file? The interface only needs to be the functions at the end.
The request to move the
ObjectMonitorTableto a separate new file came from this review comment: #27915 (comment)By moving the
ObjectMonitorTableimplementation out ofruntime/synchronizer.cppintoruntime/objectMonitorTable.[ch]ppwill make a future transition from the currentObjectMonitorTableimplementation to a new (and better) implementation appear more clean.Passes tier1-7 without any problems that can be traced to this PR.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28565/head:pull/28565$ git checkout pull/28565Update a local copy of the PR:
$ git checkout pull/28565$ git pull https://git.openjdk.org/jdk.git pull/28565/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28565View PR using the GUI difftool:
$ git pr show -t 28565Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28565.diff
Using Webrev
Link to Webrev Comment