Skip to content

Conversation

@fbredber
Copy link
Contributor

@fbredber fbredber commented Nov 29, 2025

The request to move the ObjectMonitorTable to a separate new file came from this review comment: #27915 (comment)

By moving the ObjectMonitorTable implementation out of runtime/synchronizer.cpp into runtime/objectMonitorTable.[ch]pp will make a future transition from the current ObjectMonitorTable implementation to a new (and better) implementation appear more clean.

Passes tier1-7 without any problems that can be traced to this PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371347: Move the ObjectMonitorTable to a separate new file (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28565/head:pull/28565
$ git checkout pull/28565

Update a local copy of the PR:
$ git checkout pull/28565
$ git pull https://git.openjdk.org/jdk.git pull/28565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28565

View PR using the GUI difftool:
$ git pr show -t 28565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28565.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2025

👋 Welcome back fbredberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

@fbredber This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371347: Move the ObjectMonitorTable to a separate new file

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 282f339: 8369432: Add Support for JDBC 4.5 MR

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

@fbredber The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@fbredber fbredber marked this pull request as ready for review November 29, 2025 19:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I did not verify line by line :)

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2025
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're able to hide more of the implementation in the cpp file it'll be less dramatic when you change it.

#define SHARE_RUNTIME_OBJECTMONITORTABLE_HPP

class ObjectMonitorTable : AllStatic {
struct Config {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you hide all of this in the .cpp file like symbolTable.cpp hides the CHT implementation instead of having it all in the hpp file? The interface only needs to be the functions at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants