-
Notifications
You must be signed in to change notification settings - Fork 1k
Kotlin coroutines and ktor metadata #15295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaydeluca
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
jaydeluca:kotlin-ktor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
16101cc
Kotlin and ktor metadata
jaydeluca 16e30ad
remove unneeded config
jaydeluca a468e83
fix
jaydeluca ce7699b
use library instead
jaydeluca e1f1568
Merge branch 'main' into kotlin-ktor
jaydeluca d4989a3
remove unneeded config
jaydeluca be6b06b
Merge branch 'main' into kotlin-ktor
jaydeluca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| description: > | ||
| This instrumentation enables context propagation for Kotlin coroutines and adds support for | ||
| @WithSpan annotations on Kotlin suspend functions, it does not emit any telemetry on its own. | ||
| display_name: Kotlin Coroutines | ||
| features: | ||
| - CONTEXT_PROPAGATION | ||
| library_link: https://github.com/Kotlin/kotlinx.coroutines |
5 changes: 5 additions & 0 deletions
5
instrumentation/kotlinx-coroutines/kotlinx-coroutines-flow-1.3/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| description: > | ||
| This instrumentation adds support for @WithSpan annotations on methods that return Kotlin Flow, | ||
| it does not emit any telemetry on its own. | ||
| display_name: Kotlin Coroutines Flow | ||
| library_link: https://github.com/Kotlin/kotlinx.coroutines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| description: This standalone instrumentation enables HTTP server spans and HTTP server metrics for the Ktor server. | ||
| semantic_conventions: | ||
| - HTTP_SERVER_SPANS | ||
| - HTTP_SERVER_METRICS | ||
| features: | ||
| - HTTP_ROUTE | ||
| library_link: https://ktor.io/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| description: > | ||
| This instrumentation provides HTTP server spans and HTTP server metrics for the Ktor server, | ||
| and HTTP client spans and HTTP client metrics for the Ktor HTTP client. | ||
| semantic_conventions: | ||
| - HTTP_SERVER_SPANS | ||
| - HTTP_SERVER_METRICS | ||
| - HTTP_CLIENT_SPANS | ||
| - HTTP_CLIENT_METRICS | ||
| features: | ||
| - HTTP_ROUTE | ||
| library_link: https://ktor.io/ | ||
| configurations: | ||
| - name: otel.instrumentation.http.known-methods | ||
| description: > | ||
| Configures the instrumentation to recognize an alternative set of HTTP request methods. All | ||
| other methods will be treated as `_OTHER`. | ||
| type: list | ||
| default: "CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE" | ||
| - name: otel.instrumentation.http.server.capture-request-headers | ||
| description: List of HTTP request headers to capture in HTTP server telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.server.capture-response-headers | ||
| description: List of HTTP response headers to capture in HTTP server telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.server.emit-experimental-telemetry | ||
| description: > | ||
| Enable the capture of experimental HTTP server telemetry. Adds the `http.request.body.size` | ||
| and `http.response.body.size` attributes to spans, and records `http.server.request.size` and | ||
| `http.server.response.size` metrics. | ||
| type: boolean | ||
| default: false | ||
| - name: otel.instrumentation.http.client.capture-request-headers | ||
| description: List of HTTP request headers to capture in HTTP client telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.client.capture-response-headers | ||
| description: List of HTTP response headers to capture in HTTP client telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.common.peer-service-mapping | ||
| description: Used to specify a mapping from host names or IP addresses to peer services. | ||
| type: map | ||
| default: "" | ||
| - name: otel.instrumentation.http.client.emit-experimental-telemetry | ||
| description: > | ||
| Enable the capture of experimental HTTP client telemetry. Adds the `http.request.body.size` | ||
| and `http.response.body.size` attributes to spans, and records `http.client.request.size` and | ||
| `http.client.response.size` metrics. | ||
| type: boolean | ||
| default: false | ||
| - name: otel.instrumentation.http.client.experimental.redact-query-parameters | ||
| description: Redact sensitive URL parameters. See https://opentelemetry.io/docs/specs/semconv/http/http-spans. | ||
| type: boolean | ||
| default: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| description: > | ||
| This instrumentation provides HTTP server spans and HTTP server metrics for the Ktor server, | ||
| and HTTP client spans and HTTP client metrics for the Ktor HTTP client. | ||
| semantic_conventions: | ||
| - HTTP_SERVER_SPANS | ||
| - HTTP_SERVER_METRICS | ||
| - HTTP_CLIENT_SPANS | ||
| - HTTP_CLIENT_METRICS | ||
| features: | ||
| - HTTP_ROUTE | ||
| library_link: https://ktor.io/ | ||
| configurations: | ||
| - name: otel.instrumentation.http.known-methods | ||
| description: > | ||
| Configures the instrumentation to recognize an alternative set of HTTP request methods. All | ||
| other methods will be treated as `_OTHER`. | ||
| type: list | ||
| default: "CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE" | ||
| - name: otel.instrumentation.http.server.capture-request-headers | ||
| description: List of HTTP request headers to capture in HTTP server telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.server.capture-response-headers | ||
| description: List of HTTP response headers to capture in HTTP server telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.server.emit-experimental-telemetry | ||
| description: > | ||
| Enable the capture of experimental HTTP server telemetry. Adds the `http.request.body.size` | ||
| and `http.response.body.size` attributes to spans, and records `http.server.request.size` and | ||
| `http.server.response.size` metrics. | ||
| type: boolean | ||
| default: false | ||
| - name: otel.instrumentation.http.client.capture-request-headers | ||
| description: List of HTTP request headers to capture in HTTP client telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.http.client.capture-response-headers | ||
| description: List of HTTP response headers to capture in HTTP client telemetry. | ||
| type: list | ||
| default: "" | ||
| - name: otel.instrumentation.common.peer-service-mapping | ||
| description: Used to specify a mapping from host names or IP addresses to peer services. | ||
| type: map | ||
| default: "" | ||
| - name: otel.instrumentation.http.client.emit-experimental-telemetry | ||
| description: > | ||
| Enable the capture of experimental HTTP client telemetry. Adds the `http.request.body.size` | ||
| and `http.response.body.size` attributes to spans, and records `http.client.request.size` and | ||
| `http.client.response.size` metrics. | ||
| type: boolean | ||
| default: false | ||
| - name: otel.instrumentation.http.client.experimental.redact-query-parameters | ||
| description: Redact sensitive URL parameters. See https://opentelemetry.io/docs/specs/semconv/http/http-spans. | ||
| type: boolean | ||
| default: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this system property isn't relevant to this instrumentation