Kotlin coroutines and ktor metadata #15295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
commented
Nov 14, 2025
| } | ||
|
|
||
| tasks.withType<Test>().configureEach { | ||
| jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true") |
Member
Author
There was a problem hiding this comment.
this system property isn't relevant to this instrumentation
laurit
reviewed
Nov 14, 2025
docs/instrumentation-list.yaml
Outdated
| - org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:[1.3.9,) | ||
| - org.jetbrains.kotlinx:kotlinx-coroutines-core:[1.0.0,1.3.8) | ||
| configurations: | ||
| - name: otel.instrumentation.kotlinx-coroutines.check-class |
Contributor
There was a problem hiding this comment.
Should we document this option at all?
Member
Author
There was a problem hiding this comment.
do you think it's needed to have a separate config for this, since it also uses the general debug config option too?
laurit
reviewed
Nov 14, 2025
| description: | | ||
| This instrumentation enables HTTP client spans and HTTP client metrics for the Ktor HTTP client, and enriches HTTP server spans with route information for the Ktor server. | ||
| semantic_conventions: | ||
| - HTTP_CLIENT_SPANS |
Contributor
There was a problem hiding this comment.
doesn't it also create server spans?
Member
Author
There was a problem hiding this comment.
thanks, i got thrown off course because the javaagent server spans are suppressed due to already existing netty server spans. I've updated 2.0 and 3.0 to use the library tests instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14096