feat: Support trailing dot in flagd host #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow hosts with a trailing dot as they're perfectly valid and can significantly increase performance in certain scenarios. Signed-off-by: Artem Stoianov <[email protected]>
Co-authored-by: Chris Lightfoot-Wild <[email protected]> Signed-off-by: Artem Stoianov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Allows hosts with a trailing dot, as they are perfectly valid and can significantly improve performance in certain scenarios.
The use-case is explained in this blog post.
tl;dr: Adding a trailing dot to hosts like
flagd.feature-flags.svc.localmay positively impact performance and resource usage under the default kube-dns resolver settings withndots:5.