Skip to content

feat: Support trailing dot in flagd host #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Support trailing dot in flagd host #133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d519f
feat: Support trailing dot in flagd host
zarianec Aug 20, 2025
b5c4ec9
Permit single trailing dot
zarianec Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/Flagd/src/config/Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

class Validator
{
private const VALID_HOST_REGEXP = '/^(([a-z0-9]|[a-z0-9][a-z0-9\-]*[a-z0-9])\.)*([a-z0-9]|[a-z0-9][a-z0-9\-]*[a-z0-9])$/i';
private const VALID_HOST_REGEXP = '/^(([a-z0-9]|[a-z0-9][a-z0-9\-]*[a-z0-9])\.*)+$/i';
private const VALID_PORT_RANGE = [1, 65535];
private const VALID_PROTOCOLS = ['grpc', 'http'];

Expand Down