Skip to content

Fix iTerm2 Settings window detection - #2244

Open
Miyou wants to merge 1 commit into
nikitabobko:mainfrom
Miyou:fix/iterm-settings-window
Open

Fix iTerm2 Settings window detection#2244
Miyou wants to merge 1 commit into
nikitabobko:mainfrom
Miyou:fix/iterm-settings-window

Conversation

@Miyou

@Miyou Miyou commented Aug 27, 2026

Copy link
Copy Markdown

iTerm2 Settings exposes AXFullScreenButton=null, like the hotkey windows ignored since #1813. The broad hotkey heuristic therefore classifies Settings as a popup, so it never reaches dialog handling or focus-follows-mouse.

Exempt AXIdentifier=mainPreferencesWindow from that filter. Its AXDialog subrole then lets the existing dialog heuristic float it, while iTerm hotkey windows remain ignored. Add a sanitized debug-windows dump as regression coverage.

#1813

PR checklist

  • Explain your changes in the relevant commit messages rather than in the PR description. The PR description does not contain more information than the commit messages.
  • Each commit explains what/why/how and motivation in its description.
  • The relevant issue is linked in the commit message.
  • The commit is an atomic change and contains no unrelated refactoring.
  • ./test.sh exits with zero exit code.
  • No merge commits; the branch is based directly on current upstream main.

iTerm2 Settings exposes AXFullScreenButton=null, like the hotkey windows ignored since nikitabobko#1813. The broad hotkey heuristic therefore classifies Settings as a popup, so it never reaches dialog handling or focus-follows-mouse.

Exempt AXIdentifier=mainPreferencesWindow from that filter. Its AXDialog subrole then lets the existing dialog heuristic float it, while iTerm hotkey windows remain ignored. Add a sanitized debug-windows dump as regression coverage.

nikitabobko#1813
@github-actions github-actions Bot added the not-actionable By default, all PRs have this label. If the PR makes sense, the label will be removed. label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-actionable By default, all PRs have this label. If the PR makes sense, the label will be removed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant