Fix iTerm2 Settings window detection - #2244
Open
Miyou wants to merge 1 commit into
Open
Conversation
iTerm2 Settings exposes AXFullScreenButton=null, like the hotkey windows ignored since nikitabobko#1813. The broad hotkey heuristic therefore classifies Settings as a popup, so it never reaches dialog handling or focus-follows-mouse. Exempt AXIdentifier=mainPreferencesWindow from that filter. Its AXDialog subrole then lets the existing dialog heuristic float it, while iTerm hotkey windows remain ignored. Add a sanitized debug-windows dump as regression coverage. nikitabobko#1813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iTerm2 Settings exposes
AXFullScreenButton=null, like the hotkey windows ignored since #1813. The broad hotkey heuristic therefore classifies Settings as a popup, so it never reaches dialog handling or focus-follows-mouse.Exempt
AXIdentifier=mainPreferencesWindowfrom that filter. ItsAXDialogsubrole then lets the existing dialog heuristic float it, while iTerm hotkey windows remain ignored. Add a sanitizeddebug-windowsdump as regression coverage.#1813
PR checklist
./test.shexits with zero exit code.main.