Skip to content

Conversation

@mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 13, 2025

Faster drop-in replacement for pre-commit (same logs for now, but let's see how good @ewels gets in rust 😜): https://prek.j178.dev/quickstart/#already-using-pre-commit

@mashehu mashehu added this to the 3.6.0 milestone Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.62%. Comparing base (ee4e57e) to head (9a24784).
⚠️ Report is 10 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu
Copy link
Contributor Author

mashehu commented Nov 13, 2025

I also made the ID lowercase, so it is in line with how we have it in other places. We need to update the branch protection rule for that once we want to merge this PR.

@JulianFlesch
Copy link
Contributor

In .devcontainer/setup.sh we should add

# install pre-commit hooks
prek install --install-hooks

after pip isntall -r requirements.tx ....

And from .devcontainer/build-devcontaienr/Dockerfile
remove

    pre-commit install --install-hooks && \

@mashehu mashehu force-pushed the switch-to-trek branch 2 times, most recently from 50a3e60 to 1131eaf Compare November 17, 2025 10:23
@mashehu mashehu moved this from Todo to In Review in nf-core infrastructure projects Nov 25, 2025
@mashehu mashehu self-assigned this Nov 25, 2025
@mashehu mashehu merged commit ae8818d into nf-core:dev Nov 25, 2025
197 of 200 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants