-
Notifications
You must be signed in to change notification settings - Fork 893
WIP: all hisat2 modules #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxulysse
wants to merge
11
commits into
dev
Choose a base branch
from
update_hisat2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: all hisat2 modules #1913
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
efa8e73
update hisat2 build and extractsplicesits
maxulysse c509068
update hisat2 align
maxulysse f986962
Rewire hisat2_build_memory param and move strandedness logic to ext.args
maxulysse 8961c50
Fix HISAT2_BUILD call to use single tuple input
maxulysse 187d18b
Add CHANGELOG entry for PR #1913
maxulysse d92c7de
Trim CHANGELOG entry
maxulysse 732d0e0
Update tests and snapshots for hisat2 module upgrades
maxulysse 354b17d
Fix hisat2 build: use combine instead of join, update tests with sani…
maxulysse 36ff692
Update arm.config hisat2 containers
maxulysse d0e9057
Update arm.config hisat2 containers with new wave builds
maxulysse 88a5138
update hisat2/extractsplicesites
maxulysse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severity: informational - The
--samtools`` rows use a literal--prefix to imply "sub-dependency of the row above," but Markdown tables don't support that kind of nesting - it'll just render as a literal double-hyphen in the cell. This convention doesn't appear elsewhere in `CHANGELOG.md`'s history, so it looks like a one-off formatting slip rather than an established pattern. Not blocking, just cosmetic.