Attempt to stabilize flaky benchmarks#3632
Open
nvtw wants to merge 3 commits into
Open
Conversation
Rebuild the deepest primitive contact case repeatedly and require a stable face count. Increase its contact capacity for the denser analytic box SDF and link the existing analytic primitive fix to newton-physics#3150.
nvtw
marked this pull request as draft
July 24, 2026 06:58
Contributor
📝 WalkthroughWalkthroughThe hydroelastic deep-penetration test now checks repeatability across SDF rebuilds. The SDF benchmark excludes resolution 128 because of bimodal timing behavior, and the changelog references both related fixes. ChangesHydroelastic SDF stability
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nvtw
marked this pull request as ready for review
July 24, 2026 11:34
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilize SDF benchmarks by limiting gating coverage to resolutions with repeatable timings, and strengthen hydroelastic contact-surface repeatability coverage.
Checklist
CHANGELOG.mdhas been updated (if user-facing change)Test plan
Summary by CodeRabbit
Bug Fixes
Benchmarks
Documentation