Skip to content

chore: replace generic emails with GitHub references #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CybotTM merged 1 commit into from
Feb 24, 2026
Merged

chore: replace generic emails with GitHub references #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Model/JsonResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* @category Netresearch
*
* @author Various Artists <info@netresearch.de>
* @author Various Artists
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These headers now omit the email but also don’t provide a GitHub-native reference as described in the PR. Consider replacing 'Various Artists' with a GitHub org/handle or URL to make the attribution/contact direction explicit and consistent with the PR’s stated goal.

Copilot uses AI. Check for mistakes.
* @license http://www.gnu.org/licenses/agpl-3.0.html GNU AGPl 3
*
* @see http://www.netresearch.de
Expand All @@ -30,7 +30,7 @@
*
* @category Netresearch
*
* @author Various Artists <info@netresearch.de>
* @author Various Artists
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These headers now omit the email but also don’t provide a GitHub-native reference as described in the PR. Consider replacing 'Various Artists' with a GitHub org/handle or URL to make the attribution/contact direction explicit and consistent with the PR’s stated goal.

Copilot uses AI. Check for mistakes.
* @license http://www.gnu.org/licenses/agpl-3.0.html GNU AGPl 3
*
* @see http://www.netresearch.de
Expand Down
4 changes: 2 additions & 2 deletions src/Model/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* @category Netresearch
*
* @author Various Artists <info@netresearch.de>
* @author Various Artists
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: these changes remove the email address but don’t add a GitHub-native reference. If the intent is to point contributors/users to GitHub, consider adding a GitHub handle/org or URL in the @author field (and keep it consistent across both header blocks).

Copilot uses AI. Check for mistakes.
* @license http://www.gnu.org/licenses/agpl-3.0.html GNU AGPl 3
*
* @see http://www.netresearch.de
Expand All @@ -28,7 +28,7 @@
*
* @category Netresearch
*
* @author Various Artists <info@netresearch.de>
* @author Various Artists
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: these changes remove the email address but don’t add a GitHub-native reference. If the intent is to point contributors/users to GitHub, consider adding a GitHub handle/org or URL in the @author field (and keep it consistent across both header blocks).

Copilot uses AI. Check for mistakes.
* @license http://www.gnu.org/licenses/agpl-3.0.html GNU AGPl 3
*
* @see http://www.netresearch.de
Expand Down
2 changes: 1 addition & 1 deletion src/Util/PhpSpreadsheet/LOReadFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*
* @category Netresearch
*
* @author Various Artists <info@netresearch.de>
* @author Various Artists
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description says these should be replaced with GitHub-native references, but the email is only removed (no GitHub reference is added). Consider updating the @author value to include a GitHub handle/org or a GitHub URL (e.g., project/org link) rather than leaving it as just 'Various Artists'.

Suggested change
* @author Various Artists
* @author Netresearch <https://github.com/netresearch>

Copilot uses AI. Check for mistakes.
* @license http://www.gnu.org/licenses/agpl-3.0.html GNU AGPl 3
*
* @see http://www.netresearch.de
Expand Down
Loading