chore: replace generic emails with GitHub references#261
Conversation
Replace generic @netresearch.de email addresses with GitHub-native mechanisms (Issues, Security Advisories, repository URLs). - Remove email from package metadata (composer.json, ext_emconf.php) - Add support/issues URLs to package metadata - Replace security contact with GitHub Security Advisories - Replace support/contact emails with GitHub Issues links - Remove email from PHP docblock @author tags - Use OCI labels in Dockerfiles
Summary of ChangesHello @CybotTM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's communication and support channels by transitioning from generic email addresses to GitHub's integrated features. This change is motivated by a desire to reduce spam and maintenance overhead associated with public email addresses, leveraging GitHub Security Advisories for private vulnerability reporting, GitHub Issues for general support, and GitHub Discussions for broader contact. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the stated goals of replacing generic email addresses with GitHub references and updating package metadata for support and vulnerability reporting. The changes are straightforward and improve the maintainability and communication channels for the project. The removal of specific email addresses from the @author tags in the PHP files is consistent with the motivation to reduce spam and maintenance overhead. The composer.json file was not included in the provided diffs, so I cannot verify the changes related to the support section or GitHub Security Advisories mentioned in the PR description. However, based on the PHP file changes, the intent is clear and well-executed.
There was a problem hiding this comment.
Pull request overview
This PR removes generic @netresearch.de email addresses from PHPDoc headers to reduce spam surface and shift contact/support to GitHub-native mechanisms.
Changes:
- Remove generic email addresses from
@authorPHPDoc tags - Standardize author attribution to omit direct email contact in public source headers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Util/PhpSpreadsheet/LOReadFilter.php | Removes email from PHPDoc @author |
| src/Model/Response.php | Removes email from two PHPDoc header blocks |
| src/Model/JsonResponse.php | Removes email from two PHPDoc header blocks |
| * @category Netresearch | ||
| * | ||
| * @author Various Artists <info@netresearch.de> | ||
| * @author Various Artists |
There was a problem hiding this comment.
The PR title/description says these should be replaced with GitHub-native references, but the email is only removed (no GitHub reference is added). Consider updating the @author value to include a GitHub handle/org or a GitHub URL (e.g., project/org link) rather than leaving it as just 'Various Artists'.
| * @author Various Artists | |
| * @author Netresearch <https://github.com/netresearch> |
| * @category Netresearch | ||
| * | ||
| * @author Various Artists <info@netresearch.de> | ||
| * @author Various Artists |
There was a problem hiding this comment.
Same as above: these changes remove the email address but don’t add a GitHub-native reference. If the intent is to point contributors/users to GitHub, consider adding a GitHub handle/org or URL in the @author field (and keep it consistent across both header blocks).
| * @category Netresearch | ||
| * | ||
| * @author Various Artists <info@netresearch.de> | ||
| * @author Various Artists |
There was a problem hiding this comment.
Same as above: these changes remove the email address but don’t add a GitHub-native reference. If the intent is to point contributors/users to GitHub, consider adding a GitHub handle/org or URL in the @author field (and keep it consistent across both header blocks).
| * @category Netresearch | ||
| * | ||
| * @author Various Artists <info@netresearch.de> | ||
| * @author Various Artists |
There was a problem hiding this comment.
These headers now omit the email but also don’t provide a GitHub-native reference as described in the PR. Consider replacing 'Various Artists' with a GitHub org/handle or URL to make the attribution/contact direction explicit and consistent with the PR’s stated goal.
| * @category Netresearch | ||
| * | ||
| * @author Various Artists <info@netresearch.de> | ||
| * @author Various Artists |
There was a problem hiding this comment.
These headers now omit the email but also don’t provide a GitHub-native reference as described in the PR. Consider replacing 'Various Artists' with a GitHub org/handle or URL to make the attribution/contact direction explicit and consistent with the PR’s stated goal.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=========================================
Coverage 81.49% 81.49%
Complexity 2579 2579
=========================================
Files 172 172
Lines 7107 7107
=========================================
Hits 5792 5792
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
@netresearch.deemail addresses with GitHub-native referencessupportsection to package metadata with Issues/Source URLsMotivation
Generic email addresses in public repositories attract spam and create maintenance overhead. GitHub provides better mechanisms for each use case:
Test plan