Skip to content

Fixes: #237 - Make circular reference detection aware of parent type to avoid false positives #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

Fixes: #237 - Make circular reference detection aware of parent type to avoid false positives #275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a57081
Filter object fields to only check one related_object_type per COT in…
bctiemann Nov 4, 2025
9a26cdc
Filter object fields to only check one related_object_type per COT in…
bctiemann Nov 4, 2025
10402ef
Merge remote-tracking branch 'origin/237-parent-aware-circular-refere…
bctiemann Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions netbox_custom_objects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,7 @@ def _has_circular_reference(self, custom_object_type, visited):
visited.add(custom_object_type.id)

# Check all object and multiobject fields in this custom object type
related_objects_checked = set()
for field in custom_object_type.fields.filter(
type__in=[
CustomFieldTypeChoices.TYPE_OBJECT,
Expand All @@ -1079,6 +1080,9 @@ def _has_circular_reference(self, custom_object_type, visited):
related_object_type__isnull=False,
related_object_type__app_label=APP_LABEL
):
if field.related_object_type in related_objects_checked:
continue
related_objects_checked.add(field.related_object_type)

# Get the related custom object type directly from the object_type relationship
try:
Expand Down