Fixes: #237 - Make circular reference detection aware of parent type to avoid false positives #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
changed the title
… _has_circular_reference
bctiemann
force-pushed
the
237-parent-aware-circular-reference-detection
branch
from
8a34e01 to
1a57081
Compare
… _has_circular_reference
…nce-detection' into 237-parent-aware-circular-reference-detection
arthanson
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #237
Makes circular reference detection able to distinguish between a genuine circular reference (COT1 -> COT2 -> COT1), and a COT2 with multiple fields pointing to the same COT1 (which is legal).
Keeps track of target
related_object_typeschecked during_has_circular_referencechecking of a field and doesn't check any one target type more than once per COT in the ancestry chain.